Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复开启自定义指标层级后, 角头数值文本未对齐 close #2957 #2966

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

lijinke666
Copy link
Member

@lijinke666 lijinke666 commented Nov 8, 2024

👀 PR includes

🐛 Bugfix

📝 Description

开启 customValueOrder 后, 角头存在虚拟 数值 单元格, 由于缺失相关主题配置, 导致文本未垂直居中

if (this.isMeasureField()) {
style = measureText || text;
} else if (this.isBolderText()) {

🖼️ Screenshot

Before After
image image

🔗 Related issue link

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

Copy link

vercel bot commented Nov 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
antvis-s2 ❌ Failed (Inspect) Nov 8, 2024 9:40am

@github-actions github-actions bot added the pr(fix) bug fix label Nov 8, 2024
@github-actions github-actions bot added the next 2.0-next 版本的问题 label Nov 8, 2024
Copy link
Contributor

github-actions bot commented Nov 8, 2024

Size Change: -1 B (0%)

Total Size: 336 kB

Filename Size Change
./packages/s2-core/dist/index.min.js 236 kB -1 B (0%)
ℹ️ View Unchanged
Filename Size
./packages/s2-core/dist/style.min.css 388 B
./packages/s2-react/dist/index.min.js 70.9 kB
./packages/s2-react/dist/style.min.css 3.77 kB
./packages/s2-vue/dist/index.min.js 23 kB
./packages/s2-vue/dist/style.min.css 1.85 kB

compressed-size-action

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.68%. Comparing base (ecdc9c8) to head (144b437).
Report is 476 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2966      +/-   ##
==========================================
+ Coverage   75.77%   80.68%   +4.91%     
==========================================
  Files         257      179      -78     
  Lines       11994    10437    -1557     
  Branches     2464     2375      -89     
==========================================
- Hits         9088     8421     -667     
+ Misses       1398      562     -836     
+ Partials     1508     1454      -54     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wjgogogo wjgogogo merged commit 6558a0d into next Nov 8, 2024
6 of 8 checks passed
@wjgogogo wjgogogo deleted the fix-2957 branch November 8, 2024 09:41
@lijinke666
Copy link
Member Author

🎉 This PR is included in version @antv/s2-v2.0.0-next.32 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lijinke666
Copy link
Member Author

🎉 This PR is included in version @antv/s2-react-components-v1.1.0-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next 2.0-next 版本的问题 pr(fix) bug fix released on @next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 cornerCellmeasureText.textBaseline 和其它 cell 的 measureText.textBaseline默认值不一样
3 participants