fix: 修复表格卸载后, 高清适配逻辑还会触发的问题 #2965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lijinke666
reviewed
Nov 8, 2024
lijinke666
approved these changes
Nov 8, 2024
|
感谢你的贡献, 该场景特殊, 就不用写单测了 |
9 tasks
|
🎉 This PR is included in version @antv/s2-v2.0.0-next.32 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👀 PR includes
✨ Feature
🎨 Enhance
🐛 Bugfix
🔧 Chore
📝 Description
项目中使用了浏览器全屏演示表格组件，并配置了缩放比例，启用了高清适配属性
在退出全屏时主动销毁了表格组件，但因为退出全屏的同时触发了
resize事件，而经过查看源码发现resize事件的处理器是异步执行并且使用了防抖函数，导致该事件的执行时机滞后于spreadsheet的销毁时机，进而导致后续过程的报错，浏览器控制台报错信息如下：在 hdAdapter 销毁后添加 destroyed 标识，并在 resize 事件处理器执行前检查是否已销毁，避免后续过程报错
🔍 Self-Check before the merge