Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复存在字段标记的 icon 时, 紧凑模式列宽计算错误出现省略号的问题 #2920

Merged
merged 2 commits into from
Oct 12, 2024

Conversation

lijinke666
Copy link
Member

@lijinke666 lijinke666 commented Oct 11, 2024

👀 PR includes

🐛 Bugfix

  • Solve the issue and close #0

📝 Description

问题: 计算列宽时只考虑了文本的宽度, 未考虑 icon 的场景, 导致出现省略号

该问题在 1.x 中 #2673 已修复, 同步代码时漏掉了相关逻辑

🖼️ Screenshot

Before After
image image

🔗 Related issue link

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

Copy link

vercel bot commented Oct 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
antvis-s2 ❌ Failed (Inspect) Oct 11, 2024 8:56am

@github-actions github-actions bot added the next 2.0-next 版本的问题 label Oct 11, 2024
@github-actions github-actions bot added the pr(fix) bug fix label Oct 11, 2024
Copy link
Contributor

Size Change: +120 B (+0.04%)

Total Size: 329 kB

Filename Size Change
./packages/s2-core/dist/index.min.js 229 kB +120 B (+0.05%)
ℹ️ View Unchanged
Filename Size
./packages/s2-core/dist/style.min.css 388 B
./packages/s2-react/dist/index.min.js 70.9 kB
./packages/s2-react/dist/style.min.css 3.88 kB
./packages/s2-vue/dist/index.min.js 22.9 kB
./packages/s2-vue/dist/style.min.css 1.97 kB

compressed-size-action

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.81%. Comparing base (ecdc9c8) to head (fac357b).
Report is 444 commits behind head on next.

Files with missing lines Patch % Lines
packages/s2-core/src/facet/pivot-facet.ts 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2920      +/-   ##
==========================================
+ Coverage   75.77%   80.81%   +5.04%     
==========================================
  Files         257      180      -77     
  Lines       11994    10425    -1569     
  Branches     2464     2362     -102     
==========================================
- Hits         9088     8425     -663     
+ Misses       1398      553     -845     
+ Partials     1508     1447      -61     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lijinke666 lijinke666 merged commit 75acbfe into next Oct 12, 2024
8 of 9 checks passed
@lijinke666 lijinke666 deleted the fix-compact-condition-icon branch October 12, 2024 02:22
@lijinke666
Copy link
Member Author

🎉 This PR is included in version @antv/s2-v2.0.0-next.29 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next 2.0-next 版本的问题 pr(fix) bug fix released on @next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants