Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 移动端动态修改touchAction #2908

Closed
wants to merge 3 commits into from

Conversation

Create-Peace
Copy link

👀 PR includes

🐛 Bugfix

📝 Description

🖼️ Screenshot

Before After

🔗 Related issue link

移动端 图表滑动到边缘 页面滚动条无法滚动

Copy link

vercel bot commented Sep 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
antvis-s2 ❌ Failed (Inspect) Dec 18, 2024 9:48am

@github-actions github-actions bot added next 2.0-next 版本的问题 pr(fix) bug fix labels Sep 25, 2024
@Create-Peace Create-Peace marked this pull request as ready for review September 25, 2024 02:16
@lijinke666
Copy link
Member

感谢你的贡献, 麻烦加一个单测, 参考 packages/s2-core/tests/spreadsheet/scroll-spec.ts

@lijinke666 lijinke666 added the 🙏 need test cases or docs 需要单元测试或者补充文档 label Sep 27, 2024
Copy link
Contributor

你好 @Create-Peace,感谢你的贡献, 为了让代码更健壮, 请根据 贡献指南 补充相应单元测试, 如果有 API 改动, 请修改 相应的文档

Hello, @Create-Peace, Thanks for your contribution. In order to make the code more robust, please add the corresponding unit tests, and update the docs if there are API changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🙏 need test cases or docs 需要单元测试或者补充文档 next 2.0-next 版本的问题 pr(fix) bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛移动端 图表滑动到边缘 页面滚动条无法滚动
2 participants