fix: 修复浏览器窗口多次放大后表格渲染模糊 close #2884 #2897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lijinke666
commented
Sep 12, 2024
| @@ -104,24 +115,34 @@ export class HdAdapter { | |||
| options: { width, height }, | |||
| } = this.spreadsheet; | |||
| const canvas = this.spreadsheet.getCanvasElement(); | |||
| const currentRatio = Math.ceil(ratio); | |||
There was a problem hiding this comment.
如果是窗口缩放场景, DPR 可能是 1.2 , 也可能是 1.2123123 这种, 没啥意义, 统一取整
Closed
5 tasks
|
Size Change: +30 B (+0.01%) Total Size: 329 kB
ℹ️ View Unchanged
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2897 +/- ##
==========================================
+ Coverage 75.77% 80.81% +5.03%
==========================================
Files 257 180 -77
Lines 11994 10412 -1582
Branches 2464 2360 -104
==========================================
- Hits 9088 8414 -674
+ Misses 1398 554 -844
+ Partials 1508 1444 -64 ☔ View full report in Codecov by Sentry. |
|
🎉 This PR is included in version @antv/s2-v2.0.0-next.28 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👀 PR includes
🐛 Bugfix
📝 Description
系分 VisualViewport resize 场景下 Mac 触控板和浏览器窗口的区分, 避免相互冲突设置错误的 DPR
🖼️ Screenshot
🔗 Related issue link
🔍 Self-Check before the merge