Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复自定义列头导出数据时, 角头文本展示错误 close #2844 #2869

Merged
merged 3 commits into from
Aug 23, 2024

Conversation

lijinke666
Copy link
Member

👀 PR includes

🐛 Bugfix

📝 Description

🖼️ Screenshot

Before After
image image

🔗 Related issue link

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

Copy link

vercel bot commented Aug 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
antvis-s2 ❌ Failed (Inspect) Aug 22, 2024 3:19am

@github-actions github-actions bot added the next 2.0-next 版本的问题 label Aug 19, 2024
@github-actions github-actions bot added the pr(fix) bug fix label Aug 19, 2024
@github-actions github-actions bot requested review from wjgogogo and wuhaiyang August 19, 2024 10:22
@lijinke666 lijinke666 linked an issue Aug 19, 2024 that may be closed by this pull request
5 tasks
@@ -228,7 +228,7 @@ province city 数值 数值 数值 数值

exports[`PivotSheet Export Test should export correct data with formatter for custom column headers 1`] = `
" 自定义节点 a-1 自定义节点 a-1 自定义节点 a-1 自定义节点 a-1 自定义节点 a-2
自定义节点 a-2 自定义节点 a-1-1 自定义节点 a-1-1 自定义节点 a-1-2
自定义节点 a-1-1 自定义节点 a-1-1 自定义节点 a-1-1 自定义节点 a-1-2
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

之前的快照是错的

Copy link
Contributor

github-actions bot commented Aug 19, 2024

Size Change: +38 B (+0.01%)

Total Size: 329 kB

Filename Size Change
./packages/s2-core/dist/index.min.js 229 kB +38 B (+0.02%)
ℹ️ View Unchanged
Filename Size
./packages/s2-core/dist/style.min.css 388 B
./packages/s2-react/dist/index.min.js 70.8 kB
./packages/s2-react/dist/style.min.css 3.88 kB
./packages/s2-vue/dist/index.min.js 22.9 kB
./packages/s2-vue/dist/style.min.css 1.97 kB

compressed-size-action

Copy link
Contributor

你好, @lijinke666 CI 执行失败, 请点击 [Details] 按钮查看, 并根据日志修复。

Hello, @lijinke666 CI run failed, please click the [Details] button for detailed log information and fix it.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.74%. Comparing base (ecdc9c8) to head (3ad37d1).
Report is 423 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2869      +/-   ##
==========================================
+ Coverage   75.77%   80.74%   +4.97%     
==========================================
  Files         257      180      -77     
  Lines       11994    10402    -1592     
  Branches     2464     2360     -104     
==========================================
- Hits         9088     8399     -689     
+ Misses       1398      556     -842     
+ Partials     1508     1447      -61     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lijinke666 lijinke666 merged commit 63dba54 into next Aug 23, 2024
8 of 9 checks passed
@lijinke666 lijinke666 deleted the fix-2844 branch August 23, 2024 08:34
@lijinke666
Copy link
Member Author

🎉 This PR is included in version @antv/s2-v2.0.0-next.27 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next 2.0-next 版本的问题 pr(fix) bug fix released on @next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 交叉表自定义列头导出数据格式错位
2 participants