-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: 完善 ViewMeta 和 CellData 文档 close #2845 #2868
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Size Change: -18 B (-0.01%) Total Size: 329 kB
ℹ️ View Unchanged
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2868 +/- ##
==========================================
+ Coverage 75.77% 80.75% +4.97%
==========================================
Files 257 180 -77
Lines 11994 10400 -1594
Branches 2464 2359 -105
==========================================
- Hits 9088 8398 -690
+ Misses 1398 556 -842
+ Partials 1508 1446 -62 ☔ View full report in Codecov by Sentry. |
const onlyShowCellText = this.spreadsheet.isTableMode(); | ||
const cellData = onlyShowCellText | ||
? ({ | ||
...(currentCellMeta as ViewMetaData), | ||
value: value || fieldValue, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dataCell 的 meta 中没有 value
和 valueField
, 是类型错误
@@ -37,68 +37,6 @@ s2.dataSet.getFieldName('type') | |||
| displayFormattedValueMap | 单元格所对应格式化后的值(用于编辑表) | `Map<string, string>` | | | |||
| getValueRangeByField | 获取数值最大最小值区间 | `(field: string) => { minValue: number, maxValue: number }` | | | |||
|
|||
### SimpleData |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -28,72 +28,6 @@ const s2DataConfig = { | |||
| sortParams | 排序参数配置 | [SortParam](#sortparam)[] | | | | |||
| filterParams | 筛选参数配置 | [FilterParam](#filterparam)[] | | | | |||
|
|||
### RawData |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
同上
🎉 This PR is included in version @antv/s2-v2.0.0-next.27 🎉 The release is available on: Your semantic-release bot 📦🚀 |
👀 PR includes
🔧 Chore
📝 Description
🖼️ Screenshot
🔗 Related issue link
close #2845
🔍 Self-Check before the merge