fix: 修复在明细表中绘制 G2 图表, 点击单元格报错 close #2843 #2864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
5 tasks
|
Size Change: +8 B (0%) Total Size: 329 kB
ℹ️ View Unchanged
|
lijinke666
commented
Aug 16, 2024
| @@ -584,7 +584,8 @@ export const getTooltipData = (params: TooltipDataParam): TooltipData => { | |||
| ? spreadsheet.dataSet.getFieldName(value) || formattedValue | |||
There was a problem hiding this comment.
该场景会兜底到 formattedValue, value 是 G2 的 Spec, 这种情况应该展示为空字符串
|
你好, @lijinke666 CI 执行失败, 请点击 [Details] 按钮查看, 并根据日志修复。 Hello, @lijinke666 CI run failed, please click the [Details] button for detailed log information and fix it. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2864 +/- ##
==========================================
+ Coverage 75.77% 80.79% +5.02%
==========================================
Files 257 180 -77
Lines 11994 10401 -1593
Branches 2464 2359 -105
==========================================
- Hits 9088 8404 -684
+ Misses 1398 554 -844
+ Partials 1508 1443 -65 ☔ View full report in Codecov by Sentry. |
|
🎉 This PR is included in version @antv/s2-v2.0.0-next.27 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👀 PR includes
🐛 Bugfix
📝 Description
明细表普通单元格点击 tooltip 展示的是自身的数值, 对于自身是图表的场景不应该渲染 tooltip, 这里是错误的把图表数据渲染在 Tooltip 的 JSX 中, 所以报错了
🖼️ Screenshot
🔗 Related issue link
🔍 Self-Check before the merge