Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 取消双击表格时浏览器默认的选中文本行为 close #2798 #2800

Merged
merged 2 commits into from
Jul 5, 2024

Conversation

lijinke666
Copy link
Member

👀 PR includes

🐛 Bugfix

📝 Description

🖼️ Screenshot

Before After
image image

🔗 Related issue link

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

Copy link

vercel bot commented Jul 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
antvis-s2 ❌ Failed (Inspect) Jul 4, 2024 2:43am

@github-actions github-actions bot added pr(fix) bug fix next 2.0-next 版本的问题 labels Jul 1, 2024
@github-actions github-actions bot requested review from wjgogogo and wuhaiyang July 1, 2024 10:00
@lijinke666 lijinke666 linked an issue Jul 1, 2024 that may be closed by this pull request
5 tasks
@lijinke666 lijinke666 changed the title fix: 取消双击表格时默认选中文本的默认浏览器行为 close #2798 fix: 取消双击表格时浏览器默认的选中文本行为 close #2798 Jul 1, 2024
Copy link
Contributor

github-actions bot commented Jul 1, 2024

Size Change: +5 B (0%)

Total Size: 326 kB

Filename Size Change
./packages/s2-core/dist/index.min.js 228 kB +5 B (0%)
ℹ️ View Unchanged
Filename Size
./packages/s2-core/dist/style.min.css 388 B
./packages/s2-react/dist/index.min.js 69.8 kB
./packages/s2-react/dist/style.min.css 3.88 kB
./packages/s2-vue/dist/index.min.js 22 kB
./packages/s2-vue/dist/style.min.css 1.97 kB

compressed-size-action

Copy link
Contributor

github-actions bot commented Jul 1, 2024

你好, @lijinke666 CI 执行失败, 请点击 [Details] 按钮查看, 并根据日志修复。

Hello, @lijinke666 CI run failed, please click the [Details] button for detailed log information and fix it.

@github-actions github-actions bot added the 🚨 test failed 单元测试挂了 label Jul 1, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.16%. Comparing base (ecdc9c8) to head (a68dd3c).
Report is 398 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2800      +/-   ##
==========================================
+ Coverage   75.77%   80.16%   +4.39%     
==========================================
  Files         257      180      -77     
  Lines       11994    10332    -1662     
  Branches     2464     2331     -133     
==========================================
- Hits         9088     8283     -805     
+ Misses       1398      607     -791     
+ Partials     1508     1442      -66     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lijinke666 lijinke666 merged commit 5df9326 into next Jul 5, 2024
8 of 9 checks passed
@lijinke666 lijinke666 deleted the fix-2798 branch July 5, 2024 08:01
@lijinke666
Copy link
Member Author

🎉 This PR is included in version @antv/s2-v2.0.0-next.25 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lijinke666
Copy link
Member Author

🎉 This PR is included in version @antv/s2-react-v2.0.0-next.24 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next 2.0-next 版本的问题 pr(fix) bug fix released on @next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 表格区域双击时会选择表格外的文本
3 participants