Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: 修复通过 2.0 官网图表示例的 '在 CodeSandbox 中打开', 错误的安装了 1.x 版本的问题 #2765

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

lijinke666
Copy link
Member

@lijinke666 lijinke666 commented Jun 5, 2024

👀 PR includes

🔧 Chore

  • Test case
  • Docs / demos update
  • CI / workflow
  • Release version
  • Other ()

📝 Description

该配置在 dumi-theme-antv 的主题包中, 会透传给 CodeSandbox, Riddle 之类的, 默认指向 latest, 手动修改下配置, 安装 next 版本.

https://github.com/antvis/dumi-theme-antv/blob/5936407f5e50fb83f2461f2bc809ba8af1e2b3ff/src/slots/CodeEditor/Toolbar.tsx#L122-L145

🖼️ Screenshot

Before After
image image

🔗 Related issue link

#2761

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

Copy link

vercel bot commented Jun 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
antvis-s2 ❌ Failed (Inspect) Jun 5, 2024 6:43am

@github-actions github-actions bot added pr(documentation) documentation next 2.0-next 版本的问题 labels Jun 5, 2024
@github-actions github-actions bot requested review from wjgogogo and wuhaiyang June 5, 2024 06:44
Copy link
Contributor

github-actions bot commented Jun 5, 2024

Size Change: 0 B

Total Size: 322 kB

ℹ️ View Unchanged
Filename Size
./packages/s2-core/dist/index.min.js 226 kB
./packages/s2-core/dist/style.min.css 402 B
./packages/s2-react/dist/index.min.js 68.8 kB
./packages/s2-react/dist/style.min.css 3.92 kB
./packages/s2-vue/dist/index.min.js 20.9 kB
./packages/s2-vue/dist/style.min.css 1.99 kB

compressed-size-action

Copy link
Contributor

github-actions bot commented Jun 5, 2024

你好, @lijinke666 CI 执行失败, 请点击 [Details] 按钮查看, 并根据日志修复。

Hello, @lijinke666 CI run failed, please click the [Details] button for detailed log information and fix it.

@github-actions github-actions bot added 🚨 test failed 单元测试挂了 and removed 🚨 test failed 单元测试挂了 labels Jun 5, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.16%. Comparing base (ecdc9c8) to head (fe55d23).
Report is 382 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2765      +/-   ##
==========================================
+ Coverage   75.77%   80.16%   +4.39%     
==========================================
  Files         257      176      -81     
  Lines       11994    10210    -1784     
  Branches     2464     2311     -153     
==========================================
- Hits         9088     8185     -903     
+ Misses       1398      599     -799     
+ Partials     1508     1426      -82     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lijinke666 lijinke666 merged commit 2e75fd2 into next Jun 6, 2024
14 of 15 checks passed
@lijinke666 lijinke666 deleted the fix-codesandbox branch June 6, 2024 03:16
@lijinke666
Copy link
Member Author

🎉 This PR is included in version @antv/s2-react-v2.0.0-next.23 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next 2.0-next 版本的问题 pr(documentation) documentation released on @next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants