Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components): 组件层更新时增加 loading 效果 close #1790 #2762

Merged
merged 6 commits into from
Jun 11, 2024

Conversation

lijinke666
Copy link
Member

@lijinke666 lijinke666 commented Jun 3, 2024

👀 PR includes

✨ Feature

  • New feature

🐛 Bugfix

📝 Description

  1. 数据/配置更新时增加 loading 效果 (s2-react/s2-vue), 大数据量的情况下更新感知更明显.
  2. 修复部分 render 场景未适配异步的问题 close 🐛@antv/s2-react 2.0.0-next.21版本, React组件内置重渲染render仍为同步模式,频繁更新组件导致渲染重影异常 #2752
  3. reBuildDataSet 更名为 rebuildDataSet (其实应该叫 rebuildDataset, 但是为了保持统一没改)
  4. onSheetUpdate 更名为 onUpdate, 和 onMoutned, onDestroy 保持统一, 并新增 onUpdateAfterRender hook
- <SheetComponennt onSheetUpdate={} />
+ <SheetComponennt onUpdate={} onUpdateAfterRender={} />

🖼️ Screenshot

Before After

🔗 Related issue link

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

Copy link

vercel bot commented Jun 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
antvis-s2 ❌ Failed (Inspect) Jun 11, 2024 8:17am

@github-actions github-actions bot added the pr(feature) new feature label Jun 3, 2024
@github-actions github-actions bot requested review from wjgogogo and wuhaiyang June 3, 2024 11:48
@github-actions github-actions bot added the next 2.0-next 版本的问题 label Jun 3, 2024
Copy link
Contributor

github-actions bot commented Jun 3, 2024

Size Change: +556 B (+0.17%)

Total Size: 325 kB

Filename Size Change
./packages/s2-core/dist/index.min.js 228 kB +235 B (+0.1%)
./packages/s2-react/dist/index.min.js 69.3 kB +66 B (+0.1%)
./packages/s2-vue/dist/index.min.js 21.4 kB +255 B (+1.2%)
ℹ️ View Unchanged
Filename Size
./packages/s2-core/dist/style.min.css 402 B
./packages/s2-react/dist/style.min.css 3.9 kB
./packages/s2-vue/dist/style.min.css 1.98 kB

compressed-size-action

Copy link
Contributor

github-actions bot commented Jun 3, 2024

你好, @lijinke666 CI 执行失败, 请点击 [Details] 按钮查看, 并根据日志修复。

Hello, @lijinke666 CI run failed, please click the [Details] button for detailed log information and fix it.

@github-actions github-actions bot added the 🚨 test failed 单元测试挂了 label Jun 3, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 60.00000% with 22 lines in your changes missing coverage. Please review.

Project coverage is 80.12%. Comparing base (ecdc9c8) to head (d5a18c3).
Report is 383 commits behind head on next.

Files Patch % Lines
...sheets/editable-sheet/drag-copy/drag-copy-mask.tsx 25.00% 11 Missing and 1 partial ⚠️
packages/s2-react/src/hooks/useSpreadSheet.ts 57.89% 1 Missing and 7 partials ⚠️
packages/s2-core/src/sheet-type/pivot-sheet.ts 80.00% 0 Missing and 1 partial ⚠️
packages/s2-core/src/sheet-type/spread-sheet.ts 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2762      +/-   ##
==========================================
+ Coverage   75.77%   80.12%   +4.35%     
==========================================
  Files         257      176      -81     
  Lines       11994    10216    -1778     
  Branches     2464     2313     -151     
==========================================
- Hits         9088     8186     -902     
+ Misses       1398      600     -798     
+ Partials     1508     1430      -78     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lijinke666 lijinke666 merged commit 0ca8413 into next Jun 11, 2024
8 of 9 checks passed
@lijinke666 lijinke666 deleted the feat-loading branch June 11, 2024 08:23
@lijinke666
Copy link
Member Author

🎉 This PR is included in version @antv/s2-v2.0.0-next.24 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lijinke666
Copy link
Member Author

🎉 This PR is included in version @antv/s2-react-v2.0.0-next.23 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lijinke666
Copy link
Member Author

🎉 This PR is included in version @antv/s2-vue-v2.0.0-next.15 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next 2.0-next 版本的问题 pr(feature) new feature released on @next
Projects
None yet
3 participants