chore(react-componnets): 分析配置组件包初始化 #2751

lijinke666 · 2024-05-29T09:00:12Z

👀 PR includes

🔧 Chore

📝 Description

确定的点:

新增主题风格配置面板/宽高调整面板/文本对齐三个配置组件

后面可以做的 (待讨论的点):

现有分析组件 (行列切换/高级排序) 等从 s2-react 迁移至 s2-react-components 中, 很多人其实不需要用到这些, 包解耦, 减少体积

移除 SheetComponents 的 header (switcher/advanceSort) 配置, 只保留导出, 如果需要使用分析组件, 自行组合使用即可.

该 PR 改动点:

初始化 s2-react-components 包
React 升级到 18.3, 移除废弃的 defaultProps 写法
新增 prettier-plugin-packagejson 和 prettier-plugin-organize-imports 插件, 自动移除未使用的导入 (全量格式化)
修复 pnpm 和 typescript 类型 reference 问题

🖼️ Screenshot

Before	After
❌	✅

🔗 Related issue link

🔍 Self-Check before the merge

Add or update relevant docs.
Add or update relevant demos.
Add or update test case.
Add or update relevant TypeScript definitions.

vercel · 2024-05-29T09:00:19Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
antvis-s2	❌ Failed (Inspect)			Jun 3, 2024 9:05am

github-actions · 2024-05-29T09:01:40Z

你好, @lijinke666 CI 执行失败, 请点击 [Details] 按钮查看, 并根据日志修复。

Hello, @lijinke666 CI run failed, please click the [Details] button for detailed log information and fix it.

github-actions · 2024-05-29T09:05:22Z

Size Change: -1.11 kB (-0.34%)

Total Size: 322 kB

Filename	Size	Change
`./packages/s2-core/dist/index.min.js`	226 kB	-432 B (-0.19%)
`./packages/s2-react/dist/index.min.js`	68.8 kB	-550 B (-0.79%)
`./packages/s2-react/dist/style.min.css`	3.92 kB	-7 B (-0.18%)
`./packages/s2-vue/dist/index.min.js`	20.9 kB	-121 B (-0.58%)

ℹ️ View Unchanged

Filename	Size
`./packages/s2-core/dist/style.min.css`	402 B
`./packages/s2-vue/dist/style.min.css`	1.99 kB

_{compressed-size-action}

lijinke666 · 2024-05-30T08:23:40Z

packages/s2-react/__tests__/bugs/issue-522-spec.tsx


 let sheetInstance: SpreadSheet;

 function MainLayout() {
-  const options: SheetComponentsProps['options'] = {


类型名一直是错的, 多了一个 s, 和 SheetComponentOptions 保持一致

lijinke666 · 2024-05-30T08:25:12Z

packages/s2-react/src/components/tooltip/components/operator.tsx

@@ -1,12 +1,11 @@
 import { TOOLTIP_PREFIX_CLS } from '@antv/s2';
-import { Menu } from 'antd';
-import type { ItemType } from 'antd/lib/menu/hooks/useItems';


新版本的 antd 可以通过 GetProp 工具体操取内部未导出的 props 了

lijinke666 · 2024-05-30T08:25:46Z

packages/s2-react/src/components/tooltip/components/operator.tsx

@@ -79,8 +80,3 @@ export const TooltipOperator: React.FC<Required<TooltipOperatorProps>> =
  });

 TooltipOperator.displayName = 'TooltipOperator';
-TooltipOperator.defaultProps = {


React 18.3.0 废弃了 defaultProps

lijinke666 · 2024-05-30T08:26:45Z

packages/s2-react/src/hooks/usePagination.ts


 const DEFAULT_PAGE_SIZE = 10;
 const DEFAULT_PAGE_NUMBER = 1;

-export const usePagination = (s2: SpreadSheet, props: SheetComponentsProps) => {
+export const usePagination = (


这里 typescript 自动推导有问题, 会导致打包错误, 之前的这个方案不稳定, 而且会引一个额外的包.

修改为显式声明

wjgogogo · 2024-05-31T06:23:45Z

ref: #1790，看看这个是不是可以顺带优化

lijinke666 · 2024-05-31T07:19:04Z

ref: #1790，看看这个是不是可以顺带优化

可以, 后面分不同的 PR 优化吧, 这个 PR 只做初始化和代码格式化

…onnets

codecov-commenter · 2024-06-03T09:13:22Z

Codecov Report

Attention: Patch coverage is 97.67442% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 80.16%. Comparing base (ecdc9c8) to head (15ae8bd).
Report is 380 commits behind head on next.

Files	Patch %	Lines
packages/s2-core/src/cell/data-cell.ts	50.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             next    #2751      +/-   ##
==========================================
+ Coverage   75.77%   80.16%   +4.39%     
==========================================
  Files         257      176      -81     
  Lines       11994    10210    -1784     
  Branches     2464     2311     -153     
==========================================
- Hits         9088     8185     -903     
+ Misses       1398      599     -799     
+ Partials     1508     1426      -82

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lijinke666 · 2024-06-21T10:14:27Z

🎉 This PR is included in version @antv/s2-v2.0.0-next.24 🎉

The release is available on:

Your semantic-release bot 📦🚀

lijinke666 · 2024-06-21T10:16:55Z

🎉 This PR is included in version @antv/s2-react-v2.0.0-next.23 🎉

The release is available on:

Your semantic-release bot 📦🚀

lijinke666 · 2024-06-21T10:18:58Z

🎉 This PR is included in version @antv/s2-vue-v2.0.0-next.15 🎉

The release is available on:

Your semantic-release bot 📦🚀

lijinke666 · 2024-09-18T11:31:22Z

🎉 This PR is included in version @antv/s2-react-components-v1.0.0-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

chore(react-componnets): 分析配置组件包初始化

3ae21d2

github-actions bot added the next 2.0-next 版本的问题 label May 29, 2024

github-actions bot assigned lijinke666 May 29, 2024

github-actions bot requested review from wjgogogo and wuhaiyang May 29, 2024 09:00

vercel bot had a problem deploying to Preview May 29, 2024 09:00 Failure

github-actions bot added 🚨 lint failed 静态检查失败 🚨 test failed 单元测试挂了 labels May 29, 2024

chore: 修复打包配置和 React 18.3 defaultProps warning

12a4408

vercel bot had a problem deploying to Preview May 30, 2024 06:53 Failure

build: 修复 pnpm 类型 reference 问题

54ffdd0

lijinke666 changed the title ~~[WIP] chore(react-componnets): 分析配置组件包初始化~~ chore(react-componnets): 分析配置组件包初始化 May 30, 2024

github-actions bot added the pr(chore) configuration changes label May 30, 2024

vercel bot had a problem deploying to Preview May 30, 2024 08:20 Failure

lijinke666 commented May 30, 2024

View reviewed changes

build: 还原 core 打包配置

444d9bd

vercel bot had a problem deploying to Preview May 30, 2024 08:29 Failure

chore: 更新 lock 文件

1d7fdea

vercel bot had a problem deploying to Preview May 31, 2024 06:03 Failure

style: 全量格式化

0681f9e

vercel bot had a problem deploying to Preview May 31, 2024 07:23 Failure

Merge remote-tracking branch 'origin/next' into chore-init-react-comp…

5080ab7

…onnets

vercel bot had a problem deploying to Preview June 3, 2024 02:50 Failure

Merge remote-tracking branch 'origin/next' into chore-init-react-comp…

a31685c

…onnets

vercel bot had a problem deploying to Preview June 3, 2024 03:47 Failure

build: 修复打包失败

9c837ed

vercel bot had a problem deploying to Preview June 3, 2024 07:58 Failure

build: 修复打包失败

6f0e2ae

vercel bot had a problem deploying to Preview June 3, 2024 08:07 Failure

github-actions bot removed the 🚨 lint failed 静态检查失败 label Jun 3, 2024

test: 更新快照

15ae8bd

vercel bot had a problem deploying to Preview June 3, 2024 09:05 Failure

github-actions bot removed the 🚨 test failed 单元测试挂了 label Jun 3, 2024

wjgogogo approved these changes Jun 3, 2024

View reviewed changes

lijinke666 merged commit afd48ac into next Jun 3, 2024
8 of 9 checks passed

lijinke666 deleted the chore-init-react-componnets branch June 3, 2024 09:47

lijinke666 added the released on @next label Jun 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(react-componnets): 分析配置组件包初始化 #2751

chore(react-componnets): 分析配置组件包初始化 #2751

lijinke666 commented May 29, 2024 •

edited

Loading

vercel bot commented May 29, 2024 •

edited

Loading

github-actions bot commented May 29, 2024 •

edited

Loading

github-actions bot commented May 29, 2024 •

edited

Loading

lijinke666 May 30, 2024

lijinke666 May 30, 2024

lijinke666 May 30, 2024

lijinke666 May 30, 2024 •

edited

Loading

wjgogogo commented May 31, 2024

lijinke666 commented May 31, 2024

codecov-commenter commented Jun 3, 2024

lijinke666 commented Jun 21, 2024

lijinke666 commented Jun 21, 2024

lijinke666 commented Jun 21, 2024

lijinke666 commented Sep 18, 2024

chore(react-componnets): 分析配置组件包初始化 #2751

chore(react-componnets): 分析配置组件包初始化 #2751

Conversation

lijinke666 commented May 29, 2024 • edited Loading

👀 PR includes

📝 Description

🖼️ Screenshot

🔗 Related issue link

🔍 Self-Check before the merge

vercel bot commented May 29, 2024 • edited Loading

github-actions bot commented May 29, 2024 • edited Loading

github-actions bot commented May 29, 2024 • edited Loading

lijinke666 May 30, 2024

Choose a reason for hiding this comment

lijinke666 May 30, 2024

Choose a reason for hiding this comment

lijinke666 May 30, 2024

Choose a reason for hiding this comment

lijinke666 May 30, 2024 • edited Loading

Choose a reason for hiding this comment

wjgogogo commented May 31, 2024

lijinke666 commented May 31, 2024

codecov-commenter commented Jun 3, 2024

Codecov Report

lijinke666 commented Jun 21, 2024

lijinke666 commented Jun 21, 2024

lijinke666 commented Jun 21, 2024

lijinke666 commented Sep 18, 2024

lijinke666 commented May 29, 2024 •

edited

Loading

vercel bot commented May 29, 2024 •

edited

Loading

github-actions bot commented May 29, 2024 •

edited

Loading

github-actions bot commented May 29, 2024 •

edited

Loading

lijinke666 May 30, 2024 •

edited

Loading