Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复滚动边界问题 close #2720 #2721

Merged
merged 1 commit into from
May 14, 2024
Merged

Conversation

wyh888
Copy link
Contributor

@wyh888 wyh888 commented May 13, 2024

👀 PR includes

🐛 Bugfix

📝 Description

背景

滚动表格的时候,表格和父容器的滚动条会同时滚动:

file

原因

image

passive 设置为 true 使浏览器忽略了 preventDefault,滚动事件会冒泡到父元素,导致父元素开始滚动。

🖼️ Screenshot

Before After
file 3

🔗 Related issue link

close #2720

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

Copy link

vercel bot commented May 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
antvis-s2 ❌ Failed (Inspect) May 13, 2024 6:14am

@github-actions github-actions bot added the pr(fix) bug fix label May 13, 2024
@github-actions github-actions bot added the next 2.0-next 版本的问题 label May 13, 2024
@wjgogogo wjgogogo merged commit 24591fb into antvis:next May 14, 2024
12 of 13 checks passed
@lijinke666
Copy link
Member

🎉 This PR is included in version @antv/s2-v2.0.0-next.21 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next 2.0-next 版本的问题 pr(fix) bug fix released on @next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants