fix: 修复导出 CSV 时分隔符错误导致的展示格式错误 close #2701 #2703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Export 组件 和 asyncGetAllPlainData, copyToClipboard 的是否异步导出参数统一为 async
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lijinke666
commented
May 8, 2024
| const pivotDataCellCopy = new PivotDataCellCopy({ | ||
| spreadsheet: sheetInstance, | ||
| isExport: true, | ||
| config: { | ||
| separator: split, | ||
| formatOptions, | ||
| customTransformer, | ||
| isAsyncExport: true, |
There was a problem hiding this comment.
透视表没有接受 async 这个参数, 所以同步复制时不生效的
lijinke666
commented
May 8, 2024
| const tableDataCellCopy = new TableDataCellCopy({ | ||
| spreadsheet: sheetInstance, | ||
| config: { | ||
| selectedCells: [], | ||
| separator: split, | ||
| formatOptions, | ||
| customTransformer, | ||
| isAsyncExport: true ?? isAsyncExport, | ||
| async: async ?? true, |
lijinke666
commented
May 8, 2024
| */ | ||
| export const copyToClipboard = ( | ||
| data: Copyable | string, | ||
| sync = false, | ||
| async = true, |
There was a problem hiding this comment.
现在有三种 sync syncCopy, isAsyncExport, 有点混乱, 所有参数统一为 async
lijinke666
commented
May 8, 2024
| @@ -82,8 +84,10 @@ export const Export: React.FC<ExportProps> = React.memo((props) => { | |||
| const downloadData = async (isFormat: boolean) => { | |||
| const data = await asyncGetAllPlainData({ | |||
| sheetInstance: sheet, | |||
| split: NewTab, | |||
| // 导出的是 csv 格式, 复制时需要以逗号分割 https://github.com/antvis/S2/issues/2701 | |||
| split: CSV_SEPARATOR, | |||
There was a problem hiding this comment.
主要是这个导致的, csv 分隔符应该是 ","
Closed
5 tasks
|
Size Change: +46 B (0%) Total Size: 320 kB
ℹ️ View Unchanged
|
|
你好, @lijinke666 CI 执行失败, 请点击 [Details] 按钮查看, 并根据日志修复。 Hello, @lijinke666 CI run failed, please click the [Details] button for detailed log information and fix it. |
wjgogogo
approved these changes
May 9, 2024
|
🎉 This PR is included in version @antv/s2-v2.0.0-next.20 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version @antv/s2-react-v2.0.0-next.19 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👀 PR includes
🐛 Bugfix
📝 Description
🖼️ Screenshot
🔗 Related issue link
close #2701
🔍 Self-Check before the merge