更新至 G 最新版本 #2629
Merged
更新至 G 最新版本 #2629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
xiaoiver
commented
Mar 26, 2024
packages/s2-react/__tests__/unit/components/sheets/chart-sheet/index-spec.tsx
Show resolved
Hide resolved
xiaoiver
commented
Mar 26, 2024
| @@ -44,6 +44,8 @@ const onDataCellRender: SheetComponentsProps['onDataCellRender'] = (cell) => { | |||
|
|
|||
| // https://g2.antv.antgroup.com/manual/extra-topics/bundle#g2stdlib | |||
| renderToMountedElement(chartOptions, { | |||
| // @ts-ignore | |||
| // FIXME: After upgrading @antv/g2, the type of group should be Group | |||
There was a problem hiding this comment.
G2 升级版还没发，所以会有 5.0 -> 6.0 类型不兼容问题，发布后需要移除。
|
有没有必要把 g 提出为 peer dependency |
wjgogogo
approved these changes
Mar 26, 2024
|
Size Change: -52.2 kB (-14%) 👏 Total Size: 318 kB
ℹ️ View Unchanged
|
lijinke666
reviewed
Mar 26, 2024
| @@ -96,7 +96,7 @@ describe('GuiIcon Tests', () => { | |||
| }); | |||
|
|
|||
| const spy = jest.spyOn(icon, 'getImage'); | |||
| const oldVal = icon.iconImageShape.style.img; | |||
| const oldVal = icon.iconImageShape.style.src; | |||
There was a problem hiding this comment.
对于 S2 只有这一个 img => src 的 break change 吗?
|
单测挂了, 看起来是升级导致的
|
lijinke666
pushed a commit
that referenced
this pull request
May 7, 2024
* WIP * 更新至 G 最新版本 (#2629) * chore: update to latest g deps * chore: update to latest g deps * chore: update to latest g deps * chore: update to latest g deps * chore: update to latest g deps * fix: 修复序号列 clipPath * fix: 处理 bbox 惰性计算的问题 * test: 单测修复 * test: 单测修复 * test: 更新 react snapshot * test: 增加 benchmark * chore: 升级 @antv/g2 * test: 单测修复 * chore: 更新 s2-site g 相关依赖 --------- Co-authored-by: xiaoiver <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👀 PR includes
更新到 G 最新版本，包括
@antv/g-canvas等相关依赖。✨ Feature
🎨 Enhance
🐛 Bugfix
🔧 Chore
📝 Description
🖼️ Screenshot
🔗 Related issue link
🔍 Self-Check before the merge