refactor: 去除多余的 TotalsStatus，只保留 TotalStatus #2623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Size Change: +49 B (0%) Total Size: 318 kB
ℹ️ View Unchanged
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #2623 +/- ##
==========================================
+ Coverage 75.77% 79.03% +3.26%
==========================================
Files 257 274 +17
Lines 11994 12392 +398
Branches 2464 2529 +65
==========================================
+ Hits 9088 9794 +706
+ Misses 1398 1061 -337
- Partials 1508 1537 +29 ☔ View full report in Codecov by Sentry. |
wjgogogo
commented
Mar 25, 2024
| @@ -112,6 +113,7 @@ export class PivotFacet extends FrozenFacet { | |||
| const isTotals = | |||
| row.isTotals || row.isTotalMeasure || col.isTotals || col.isTotalMeasure; | |||
|
|
|||
| const totalStatus = getHeaderTotalStatus(row, col); | |||
There was a problem hiding this comment.
master 上是有这个逻辑的，似乎是合代码合掉了
lijinke666
approved these changes
Mar 25, 2024
|
🎉 This PR is included in version @antv/s2-v2.0.0-next.17 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👀 PR includes
✨ Feature
🎨 Enhance
🐛 Bugfix
🔧 Chore
📝 Description
TotalsStatus， 保留TotalStatusTotalStatus中总计配置增加Grand关键字，保持风格统一🖼️ Screenshot
🔗 Related issue link
🔍 Self-Check before the merge