Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复角头和行头折叠展开 icon 的状态未同步以及展开异常的问题 close #2607 #2620

Merged
merged 3 commits into from
Mar 22, 2024

Conversation

lijinke666
Copy link
Member

👀 PR includes

🐛 Bugfix

🔧 Chore

  • Test case
  • Docs / demos update
  • CI / workflow
  • Release version
  • Other ()

📝 Description

  1. 修复行头和角头的折叠/展开 icon 状态未同步的问题
  style: {
    rowCell: {
      // 这种情况下等价于 collapseAll: true 但是角头 icon 状态不对
      collapseFields: {
        'root[&]浙江省': true,
        'root[&]四川省': true,
      },
    },
  }
  1. 修复全部折叠的情况下, 行头节点展开异常 close 透视表树结构自定义按钮渲染和展开逻辑有问题 #2607

🖼️ Screenshot

Before After
image image
image image

🔗 Related issue link

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

Copy link

vercel bot commented Mar 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
antvis-s2 ❌ Failed (Inspect) Mar 22, 2024 8:15am

@github-actions github-actions bot added the pr(fix) bug fix label Mar 22, 2024
@github-actions github-actions bot requested review from wjgogogo and wuhaiyang March 22, 2024 07:21
@github-actions github-actions bot added the next 2.0-next 版本的问题 label Mar 22, 2024
Copy link
Contributor

github-actions bot commented Mar 22, 2024

Size Change: +35 B (0%)

Total Size: 318 kB

Filename Size Change
./packages/s2-core/dist/index.min.js 222 kB +35 B (0%)
ℹ️ View Unchanged
Filename Size
./packages/s2-core/dist/style.min.css 402 B
./packages/s2-react/dist/index.min.js 69.3 kB
./packages/s2-react/dist/style.min.css 4 kB
./packages/s2-vue/dist/index.min.js 20.3 kB
./packages/s2-vue/dist/style.min.css 1.97 kB

compressed-size-action

Copy link
Contributor

你好, @lijinke666 CI 执行失败, 请点击 [Details] 按钮查看, 并根据日志修复。

Hello, @lijinke666 CI run failed, please click the [Details] button for detailed log information and fix it.

@github-actions github-actions bot added the 🚨 test failed 单元测试挂了 label Mar 22, 2024
@github-actions github-actions bot removed the 🚨 test failed 单元测试挂了 label Mar 22, 2024
@lijinke666 lijinke666 merged commit 99829a6 into next Mar 22, 2024
8 of 9 checks passed
@lijinke666 lijinke666 deleted the fix-2607 branch March 22, 2024 08:20
@lijinke666
Copy link
Member Author

🎉 This PR is included in version @antv/s2-v2.0.0-next.16 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lijinke666
Copy link
Member Author

🎉 This PR is included in version @antv/s2-react-v2.0.0-next.15 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next 2.0-next 版本的问题 pr(fix) bug fix released on @next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants