Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 移除已废弃的方法和逻辑 & 优化文档 #2566

Merged
merged 8 commits into from
Feb 29, 2024

Conversation

lijinke666
Copy link
Member

👀 PR includes

🎨 Enhance

  • Code style optimization
  • Refactoring
  • Change the UI
  • Improve the performance
  • Type optimization

📝 Description

移除一些无用 TODO 和 deprecated 的方法, 完善文档

🖼️ Screenshot

Before After

🔗 Related issue link

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

Copy link

vercel bot commented Feb 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
antvis-s2 ❌ Failed (Inspect) Feb 29, 2024 7:01am

@github-actions github-actions bot added the pr(feature) new feature label Feb 28, 2024
@github-actions github-actions bot added the next 2.0-next 版本的问题 label Feb 28, 2024
Copy link
Contributor

github-actions bot commented Feb 28, 2024

Size Change: -648 B (0%)

Total Size: 317 kB

Filename Size Change
./packages/s2-core/dist/index.min.js 221 kB -582 B (0%)
./packages/s2-react/dist/index.min.js 68.7 kB -62 B (0%)
./packages/s2-vue/dist/index.min.js 20.2 kB -4 B (0%)
ℹ️ View Unchanged
Filename Size
./packages/s2-core/dist/style.min.css 402 B
./packages/s2-react/dist/style.min.css 4.01 kB
./packages/s2-vue/dist/style.min.css 1.98 kB

compressed-size-action

Copy link
Contributor

github-actions bot commented Feb 28, 2024

你好, @lijinke666 CI 执行失败, 请点击 [Details] 按钮查看, 并根据日志修复。

Hello, @lijinke666 CI run failed, please click the [Details] button for detailed log information and fix it.

@github-actions github-actions bot added the 🚨 test failed 单元测试挂了 label Feb 28, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.61%. Comparing base (ecdc9c8) to head (24f2323).
Report is 257 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2566      +/-   ##
==========================================
+ Coverage   75.77%   78.61%   +2.84%     
==========================================
  Files         257      275      +18     
  Lines       11994    12374     +380     
  Branches     2464     2517      +53     
==========================================
+ Hits         9088     9728     +640     
+ Misses       1398     1100     -298     
- Partials     1508     1546      +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lijinke666 lijinke666 merged commit de7c97b into next Feb 29, 2024
7 of 8 checks passed
@lijinke666 lijinke666 deleted the refactor-remove-todo branch February 29, 2024 06:53
@lijinke666
Copy link
Member Author

🎉 This PR is included in version @antv/s2-v2.0.0-next.13 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lijinke666
Copy link
Member Author

🎉 This PR is included in version @antv/s2-react-v2.0.0-next.12 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lijinke666
Copy link
Member Author

🎉 This PR is included in version @antv/s2-vue-v2.0.0-next.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next 2.0-next 版本的问题 pr(feature) new feature released on @next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants