Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复父容器存在 transform 缩放时单元格刷选偏移 close #2553 #2565

Merged
merged 3 commits into from
Feb 29, 2024

Conversation

lijinke666
Copy link
Member

👀 PR includes

🐛 Bugfix

📝 Description

  1. 父容器存在 transform: scale() 时, 刷选坐标拿的有问题, 应该使用 offsetX/offsetY 而不是 clientX/clientY, 参考 G 的 supportsCSSTransform 处理方式.

https://github.com/antvis/G/blob/a43c19a662684945d0bf9dc1876af43ac26b1243/packages/g-lite/src/plugins/EventPlugin.ts#L215-L229

  1. 增加遗漏的 eventController 文档

🖼️ Screenshot

Before After
Kapture 2024-02-27 at 17 17 37 Kapture 2024-02-27 at 17 13 40

🔗 Related issue link

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

Copy link

vercel bot commented Feb 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
antvis-s2 ❌ Failed (Inspect) Feb 28, 2024 7:22am

@github-actions github-actions bot added next 2.0-next 版本的问题 pr(fix) bug fix labels Feb 27, 2024
Copy link
Contributor

github-actions bot commented Feb 27, 2024

你好, @lijinke666 CI 执行失败, 请点击 [Details] 按钮查看, 并根据日志修复。

Hello, @lijinke666 CI run failed, please click the [Details] button for detailed log information and fix it.

@github-actions github-actions bot added the 🚨 test failed 单元测试挂了 label Feb 27, 2024
Copy link
Contributor

github-actions bot commented Feb 27, 2024

Size Change: +90 B (0%)

Total Size: 317 kB

Filename Size Change
./packages/s2-core/dist/index.min.js 222 kB +90 B (0%)
ℹ️ View Unchanged
Filename Size
./packages/s2-core/dist/style.min.css 402 B
./packages/s2-react/dist/index.min.js 68.7 kB
./packages/s2-react/dist/style.min.css 4.01 kB
./packages/s2-vue/dist/index.min.js 20.2 kB
./packages/s2-vue/dist/style.min.css 1.98 kB

compressed-size-action

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 78.30%. Comparing base (ecdc9c8) to head (f36ddd3).
Report is 257 commits behind head on next.

Files Patch % Lines
...nteraction/brush-selection/base-brush-selection.ts 0.00% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2565      +/-   ##
==========================================
+ Coverage   75.77%   78.30%   +2.53%     
==========================================
  Files         257      275      +18     
  Lines       11994    12478     +484     
  Branches     2464     2539      +75     
==========================================
+ Hits         9088     9771     +683     
+ Misses       1398     1148     -250     
- Partials     1508     1559      +51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wjgogogo wjgogogo merged commit 715bbf4 into next Feb 29, 2024
8 of 9 checks passed
@wjgogogo wjgogogo deleted the fix-2553 branch February 29, 2024 03:43
@lijinke666
Copy link
Member Author

🎉 This PR is included in version @antv/s2-v2.0.0-next.13 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lijinke666
Copy link
Member Author

🎉 This PR is included in version @antv/s2-react-v2.0.0-next.12 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next 2.0-next 版本的问题 pr(fix) bug fix released on @next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants