Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复维度字段中包含 [&] 分隔符导致的获取数据不正确的问题 #2488

Merged
merged 2 commits into from
Dec 21, 2023

test: 单测补充

1b4e571
Select commit
Loading
Failed to load commit list.
Merged

fix: 修复维度字段中包含 [&] 分隔符导致的获取数据不正确的问题 #2488

test: 单测补充
1b4e571
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 21, 2023 in 0s

76.79% (+0.31%) compared to 1adc25d

View this Pull Request on Codecov

76.79% (+0.31%) compared to 1adc25d

Details

Codecov Report

Attention: 175 lines in your changes are missing coverage. Please review.

Comparison is base (1adc25d) 76.48% compared to head (1b4e571) 76.79%.
Report is 119 commits behind head on master.

Files Patch % Lines
packages/s2-core/src/cell/base-row-cell.ts 71.72% 22 Missing and 19 partials ⚠️
packages/s2-core/src/facet/frozen-facet.ts 82.58% 2 Missing and 33 partials ⚠️
packages/s2-core/src/facet/pivot-facet.ts 81.52% 4 Missing and 13 partials ⚠️
packages/s2-core/src/data-set/pivot-data-set.ts 80.32% 1 Missing and 11 partials ⚠️
...ckages/s2-core/src/facet/header/base-frozen-row.ts 85.36% 0 Missing and 6 partials ⚠️
...s/s2-core/src/facet/layout/build-gird-hierarchy.ts 82.35% 1 Missing and 5 partials ⚠️
...eraction/base-interaction/click/data-cell-click.ts 50.00% 3 Missing and 3 partials ⚠️
packages/s2-core/src/data-set/table-data-set.ts 66.66% 0 Missing and 5 partials ⚠️
packages/s2-core/src/facet/header/row.ts 58.33% 5 Missing ⚠️
packages/s2-core/src/facet/layout/layout-hooks.ts 0.00% 3 Missing and 1 partial ⚠️
... and 23 more
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2488      +/-   ##
==========================================
+ Coverage   76.48%   76.79%   +0.31%     
==========================================
  Files         240      249       +9     
  Lines       12312    12762     +450     
  Branches     2630     2746     +116     
==========================================
+ Hits         9417     9801     +384     
+ Misses       1377     1366      -11     
- Partials     1518     1595      +77

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov