Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复多列文本单元格 hover 时报错 #2472

Merged
merged 1 commit into from
Dec 12, 2023

fix: 修复多列文本单元格 hover 时报错

c6c9479
Select commit
Loading
Failed to load commit list.
Merged

fix: 修复多列文本单元格 hover 时报错 #2472

fix: 修复多列文本单元格 hover 时报错
c6c9479
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 12, 2023 in 0s

76.64% (+0.16%) compared to 1adc25d

View this Pull Request on Codecov

76.64% (+0.16%) compared to 1adc25d

Details

Codecov Report

Attention: 220 lines in your changes are missing coverage. Please review.

Comparison is base (1adc25d) 76.48% compared to head (c6c9479) 76.64%.
Report is 112 commits behind head on master.

Files Patch % Lines
packages/s2-core/src/cell/base-row-cell.ts 71.72% 22 Missing and 19 partials ⚠️
packages/s2-core/src/facet/frozen-facet.ts 82.58% 2 Missing and 33 partials ⚠️
packages/s2-core/src/facet/pivot-facet.ts 79.38% 3 Missing and 17 partials ⚠️
packages/s2-core/src/data-set/pivot-data-set.ts 72.85% 2 Missing and 17 partials ⚠️
packages/s2-core/src/utils/text.ts 42.85% 7 Missing and 1 partial ⚠️
packages/s2-core/src/data-set/table-data-set.ts 58.82% 1 Missing and 6 partials ⚠️
...ckages/s2-core/src/facet/header/base-frozen-row.ts 85.36% 0 Missing and 6 partials ⚠️
...eraction/base-interaction/click/data-cell-click.ts 50.00% 3 Missing and 3 partials ⚠️
...mponents/sheets/editable-sheet/edit-cell/index.tsx 50.00% 5 Missing and 1 partial ⚠️
packages/s2-core/src/facet/header/row.ts 58.33% 5 Missing ⚠️
... and 35 more
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2472      +/-   ##
==========================================
+ Coverage   76.48%   76.64%   +0.16%     
==========================================
  Files         240      246       +6     
  Lines       12312    12788     +476     
  Branches     2630     2756     +126     
==========================================
+ Hits         9417     9802     +385     
+ Misses       1377     1368       -9     
- Partials     1518     1618     +100

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov