Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): 去除 tooltip总和 前后多余括号 #2443

Closed
wants to merge 1 commit into from

Conversation

xulingling0
Copy link

👀 PR includes

✨ Feature

  • New feature

🎨 Enhance

  • Code style optimization
  • Refactoring
  • Change the UI
  • Improve the performance
  • Type optimization

🐛 Bugfix

  • Solve the issue and close #0

🔧 Chore

  • Test case
  • Docs / demos update
  • CI / workflow
  • Release version
  • Other ()

📝 Description

背景:#2440

🖼️ Screenshot

Before After

🔗 Related issue link

#2440

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

Copy link

vercel bot commented Dec 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
antvis-s2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 1, 2023 7:29am

@lijinke666
Copy link
Member

lijinke666 commented Dec 1, 2023

  1. 如果没有括号, 会产生歧义, 会让用户以为他自己的维值就是 "数量 总和" ("数量 (总和) => 数量 总和")
  2. vue 版本也应该加上, 这个算 bug

更好的方式我觉得是将括号加到国际化文件中, 如果不需要括号, [自定义覆盖就好]

export const ZH_CN = {
-  总和: '总和',
+  总和: '(总和)'
}

(https://s2.antv.antgroup.com/manual/basic/i18n#%E6%89%A9%E5%B1%95%E5%9B%BD%E9%99%85%E5%8C%96%E6%96%87%E6%A1%88)

export const ZH_CN = {
小计: '小计',
总计: '总计',

感谢你的 PR, 综上所述, 暂时关闭, 在 #2442 处理

@lijinke666 lijinke666 closed this Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr(fix) bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants