Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复维度缺失部分维值时, 行维值以及对应的数值展示错误 #2436

Merged
merged 5 commits into from
Nov 29, 2023

fix: field 存在时才添加占位符

6d9e2b1
Select commit
Loading
Failed to load commit list.
Merged

fix: 修复维度缺失部分维值时, 行维值以及对应的数值展示错误 #2436

fix: field 存在时才添加占位符
6d9e2b1
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 29, 2023 in 0s

76.77% (+0.29%) compared to 1adc25d

View this Pull Request on Codecov

76.77% (+0.29%) compared to 1adc25d

Details

Codecov Report

Attention: 132 lines in your changes are missing coverage. Please review.

Comparison is base (1adc25d) 76.48% compared to head (6d9e2b1) 76.77%.
Report is 97 commits behind head on master.

Files Patch % Lines
packages/s2-core/src/facet/frozen-facet.ts 86.06% 2 Missing and 26 partials ⚠️
packages/s2-core/src/data-set/pivot-data-set.ts 72.85% 2 Missing and 17 partials ⚠️
packages/s2-core/src/facet/pivot-facet.ts 81.63% 1 Missing and 8 partials ⚠️
packages/s2-core/src/utils/text.ts 42.85% 7 Missing and 1 partial ⚠️
...mponents/sheets/editable-sheet/edit-cell/index.tsx 50.00% 5 Missing and 1 partial ⚠️
...s/s2-core/src/facet/layout/build-gird-hierarchy.ts 85.29% 1 Missing and 4 partials ⚠️
packages/s2-core/src/facet/layout/layout-hooks.ts 0.00% 3 Missing and 1 partial ⚠️
...act/src/components/sheets/editable-sheet/index.tsx 33.33% 3 Missing and 1 partial ⚠️
packages/s2-core/src/facet/base-facet.ts 85.71% 0 Missing and 3 partials ⚠️
packages/s2-core/src/facet/table-facet.ts 92.10% 1 Missing and 2 partials ⚠️
... and 28 more
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2436      +/-   ##
==========================================
+ Coverage   76.48%   76.77%   +0.29%     
==========================================
  Files         240      242       +2     
  Lines       12312    12639     +327     
  Branches     2630     2726      +96     
==========================================
+ Hits         9417     9704     +287     
+ Misses       1377     1347      -30     
- Partials     1518     1588      +70

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov