Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修改editable在antd Model组件中编辑样式 #2354

Closed
wants to merge 2 commits into from
Closed

fix: 修改editable在antd Model组件中编辑样式 #2354

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc706e3
fix: 修改editable在antd Model组件中编辑样式
Sep 15, 2023
9214ae5
fix: lint fix
Sep 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/s2-react/src/components/sheets/editable-sheet/edit-cell/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ function EditCellComponent(
<div
ref={containerRef}
style={{
zIndex: 500,
zIndex: 1100,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是原本的 zIndex 低于 antd modal 的 zIndex, 所以被遮住了?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是原本的 zIndex 低于 antd modal 的 zIndex, 所以被遮住了?

是的

Copy link
Member

@lijinke666 lijinke666 Sep 15, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修改后, container 的 zIndex 大于了 TextArea 的 zIndex, 不会有问题吗? container 的 zIndex 应该始终小于 styleProps.zIndex

image

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

比如什么问题呢？

position: 'absolute',
overflow: 'hidden',
left,
Expand Down Expand Up @@ -184,6 +184,8 @@ const EditCell = memo(
{ event: e, onChange, onDataCellEditEnd, CustomComponent },
spreadsheet,
);

console.log(e)
},
[spreadsheet],
);
Expand Down