fix: 修复明细表在 dataCfg 为空, 同时开启序号列时, 错误的渲染了占位符的问题 #3042
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
你好 @lijinke666，非常感谢你的贡献. Hello, @lijinke666, Thanks for your contribution. In order to make the code more robust, please add the corresponding unit tests, and update the docs if there are API changes. |
|
Walkthrough: 这个PR修复了当 Changes:
|
![petercat-assistant[bot]](https://avatars.githubusercontent.com/in/875736?s=60&v=4){kind=small}
| (field) => field === SERIES_NUMBER_FIELD, | ||
| ); | ||
|
|
||
| return super.shouldRender() && !isOnlyContainedSeriesNumber; |
There was a problem hiding this comment.
The shouldRender method ensures that the placeholder is not rendered when only the series number column is present. This is a logical fix to prevent unnecessary rendering.
| @@ -86,6 +86,15 @@ export class TableFacet extends FrozenFacet { | |||
| this.initEmptyPlaceholderGroup(); | |||
| } | |||
|
|
|||
| protected shouldRender(): boolean { | |||
| const { fields } = this.spreadsheet.dataSet; | |||
| const isOnlyContainedSeriesNumber = fields?.columns?.every( | |||
There was a problem hiding this comment.
dataCfg 为空时, 明细表开启序号, columns 会添加 SERIES_NUMBER_FIELD, 所以 shouldRender() 没有拦截到, 这种情况不应该渲染
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3042 +/- ##
==========================================
Coverage 75.77% 75.77%
==========================================
Files 257 51 -206
Lines 11994 1490 -10504
Branches 2464 284 -2180
==========================================
- Hits 9088 1129 -7959
+ Misses 1398 210 -1188
+ Partials 1508 151 -1357 ☔ View full report in Codecov by Sentry. |
|
Size Change: +48 B (+0.01%) Total Size: 618 kB
ℹ️ View Unchanged
|
|
🎉 This PR is included in version @antv/s2-v2.1.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
👀 PR includes
🐛 Bugfix
📝 Description
🖼️ Screenshot
🔗 Related issue link
🔍 Self-Check before the merge