fix: 修复明细表在 dataCfg 为空, 同时开启序号列时, 错误的渲染了占位符的问题 (#3042)

* fix: 修复明细表在 dataCfg 为空, 同时开启序号列时, 错误的渲染了占位符的问题 * docs: 更新文档
antvis · Dec 20, 2024 · feab43f · feab43f
1 parent b3a83e7
commit feab43f
Show file tree

Hide file tree

Showing 3 changed files with 36 additions and 23 deletions.
diff --git a/packages/s2-core/__tests__/spreadsheet/table-sheet-spec.ts b/packages/s2-core/__tests__/spreadsheet/table-sheet-spec.ts
@@ -431,29 +431,32 @@ describe('TableSheet normal spec', () => {
       await expectEmptyPlaceholder(s2);
     });
 
-    test('should not render empty placeholder if all fields is empty', async () => {
-      const s2 = new TableSheet(
-        getContainer(),
-        { ...dataCfg, fields: {}, data: [] },
-        {
-          ...options,
-          frozen: {},
-          seriesNumber: {
-            enable: false,
+    test.each([{ showSeriesNumber: true }, { showSeriesNumber: false }])(
+      'should not render empty placeholder if all fields is empty for %o',
+      async ({ showSeriesNumber }) => {
+        const s2 = new TableSheet(
+          getContainer(),
+          { ...dataCfg, fields: {}, data: [] },
+          {
+            ...options,
+            frozen: {},
+            seriesNumber: {
+              enable: showSeriesNumber,
+            },
           },
-        },
-      );
-
-      await s2.render();
-      const [rect, icon, text] = (s2.facet as TableFacet).emptyPlaceholderGroup
-        .children;
-
-      expect(
-        (s2.facet as TableFacet).emptyPlaceholderGroup.children,
-      ).toHaveLength(0);
-      expect(rect).not.toBeDefined();
-      expect(icon).not.toBeDefined();
-      expect(text).not.toBeDefined();
-    });
+        );
+
+        await s2.render();
+        const [rect, icon, text] = (s2.facet as TableFacet)
+          .emptyPlaceholderGroup.children;
+
+        expect(
+          (s2.facet as TableFacet).emptyPlaceholderGroup.children,
+        ).toHaveLength(0);
+        expect(rect).not.toBeDefined();
+        expect(icon).not.toBeDefined();
+        expect(text).not.toBeDefined();
+      },
+    );
   });
 });
diff --git a/packages/s2-core/src/facet/table-facet.ts b/packages/s2-core/src/facet/table-facet.ts
@@ -86,6 +86,15 @@ export class TableFacet extends FrozenFacet {
     this.initEmptyPlaceholderGroup();
   }
 
+  protected shouldRender(): boolean {
+    const { fields } = this.spreadsheet.dataSet;
+    const isOnlyContainedSeriesNumber = fields?.columns?.every(
+      (field) => field === SERIES_NUMBER_FIELD,
+    );
+
+    return super.shouldRender() && !isOnlyContainedSeriesNumber;
+  }
+
   public render() {
     if (!this.shouldRender()) {
       return;

diff --git a/s2-site/docs/common/development.zh.md b/s2-site/docs/common/development.zh.md
@@ -44,5 +44,6 @@ pnpm react:test -- -u
 pnpm lint
 
 # 本地启动官网
+pnpm build # 首次运行官网需要先执行一次
 pnpm site:start
 ```