Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修改editable在antd Model组件中编辑样式 #2354

Closed
wants to merge 2 commits into from

Conversation

zsymor
Copy link

@zsymor zsymor commented Sep 15, 2023

👀 PR includes

style fix

🐛 Bugfix

在Antd Model组件中,editable双击input输入框样式展示不正确

📝 Description

修改s2-react中editable在Antd Model组件中,input输入框样式展示不正确

🖼️ Screenshot

| Before | After |

image

image

| ❌ | ✅ |

🔗 Related issue link

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

@vercel
Copy link

vercel bot commented Sep 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
antvis-s2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 15, 2023 8:34am

@lijinke666
Copy link
Member

@zsymor 修下 lint

@@ -137,7 +137,7 @@ function EditCellComponent(
<div
ref={containerRef}
style={{
zIndex: 500,
zIndex: 1100,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是原本的 zIndex 低于 antd modal 的 zIndex, 所以被遮住了?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是原本的 zIndex 低于 antd modal 的 zIndex, 所以被遮住了?

是的

@@ -137,7 +137,7 @@ function EditCellComponent(
<div
ref={containerRef}
style={{
zIndex: 500,
zIndex: 1100,
Copy link
Member

@lijinke666 lijinke666 Sep 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修改后, container 的 zIndex 大于了 TextArea 的 zIndex, 不会有问题吗? container 的 zIndex 应该始终小于 styleProps.zIndex

image

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

比如什么问题呢?

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Patch coverage: 70.09% and project coverage change: -0.10% ⚠️

Comparison is base (1adc25d) 76.48% compared to head (9214ae5) 76.39%.
Report is 67 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2354      +/-   ##
==========================================
- Coverage   76.48%   76.39%   -0.10%     
==========================================
  Files         240      240              
  Lines       12312    12468     +156     
  Branches     2630     2680      +50     
==========================================
+ Hits         9417     9525     +108     
+ Misses       1377     1370       -7     
- Partials     1518     1573      +55     
Files Changed Coverage Δ
packages/s2-core/src/cell/base-cell.ts 82.22% <ø> (-0.23%) ⬇️
packages/s2-core/src/cell/col-cell.ts 89.18% <ø> (-0.02%) ⬇️
packages/s2-core/src/cell/corner-cell.ts 83.33% <0.00%> (+0.64%) ⬆️
packages/s2-core/src/cell/table-col-cell.ts 86.53% <ø> (+4.72%) ⬆️
...ackages/s2-core/src/common/constant/interaction.ts 100.00% <ø> (ø)
packages/s2-core/src/data-set/base-data-set.ts 93.93% <ø> (+0.39%) ⬆️
packages/s2-core/src/data-set/pivot-data-set.ts 72.39% <0.00%> (-0.73%) ⬇️
packages/s2-core/src/data-set/table-data-set.ts 75.00% <ø> (+0.33%) ⬆️
packages/s2-core/src/sheet-type/pivot-sheet.ts 86.30% <0.00%> (+0.19%) ⬆️
packages/s2-core/src/theme/index.ts 92.30% <ø> (-7.70%) ⬇️
... and 36 more

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -184,6 +184,8 @@ const EditCell = memo(
{ event: e, onChange, onDataCellEditEnd, CustomComponent },
spreadsheet,
);

console.log(e);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为什么要加 console ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ping @zsymor

@lijinke666
Copy link
Member

lijinke666 commented Nov 17, 2023

长时间未响应, PR 暂时关闭

@lijinke666 lijinke666 closed this Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr(fix) bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants