-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 修改editable在antd Model组件中编辑样式 #2354
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@zsymor 修下 lint |
@@ -137,7 +137,7 @@ function EditCellComponent( | |||
<div | |||
ref={containerRef} | |||
style={{ | |||
zIndex: 500, | |||
zIndex: 1100, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
是原本的 zIndex 低于 antd modal 的 zIndex, 所以被遮住了?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
是原本的 zIndex 低于 antd modal 的 zIndex, 所以被遮住了?
是的
@@ -137,7 +137,7 @@ function EditCellComponent( | |||
<div | |||
ref={containerRef} | |||
style={{ | |||
zIndex: 500, | |||
zIndex: 1100, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
比如什么问题呢?
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2354 +/- ##
==========================================
- Coverage 76.48% 76.39% -0.10%
==========================================
Files 240 240
Lines 12312 12468 +156
Branches 2630 2680 +50
==========================================
+ Hits 9417 9525 +108
+ Misses 1377 1370 -7
- Partials 1518 1573 +55
☔ View full report in Codecov by Sentry. |
@@ -184,6 +184,8 @@ const EditCell = memo( | |||
{ event: e, onChange, onDataCellEditEnd, CustomComponent }, | |||
spreadsheet, | |||
); | |||
|
|||
console.log(e); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
为什么要加 console ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ping @zsymor
长时间未响应, PR 暂时关闭 |
👀 PR includes
style fix
🐛 Bugfix
在Antd Model组件中,editable双击input输入框样式展示不正确
📝 Description
修改s2-react中editable在Antd Model组件中,input输入框样式展示不正确
🖼️ Screenshot
| Before | After |
| ❌ | ✅ |
🔗 Related issue link
🔍 Self-Check before the merge