fix: 重命名

antvis · Oct 11, 2023 · 25a559e · 25a559e
1 parent 0dfe56d
commit 25a559e
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 7 deletions.
diff --git a/packages/s2-core/__tests__/unit/data-set/pivot-data-set-spec.ts b/packages/s2-core/__tests__/unit/data-set/pivot-data-set-spec.ts
@@ -160,7 +160,7 @@ describe('Pivot Dataset Test', () => {
     });
 
     test('should get correctly empty dataset result', () => {
-      expect(dataSet.isEmptyDataSet()).toBeFalsy();
+      expect(dataSet.isEmpty()).toBeFalsy();
     });
   });
 

diff --git a/packages/s2-core/__tests__/unit/data-set/table-data-set-spec.ts b/packages/s2-core/__tests__/unit/data-set/table-data-set-spec.ts
@@ -101,7 +101,7 @@ describe('Table Mode Dataset Test', () => {
     });
 
     test('should get correctly empty dataset result', () => {
-      expect(dataSet.isEmptyDataSet()).toBeFalsy();
+      expect(dataSet.isEmpty()).toBeFalsy();
     });
   });
 

diff --git a/packages/s2-core/__tests__/unit/facet/table-facet-spec.ts b/packages/s2-core/__tests__/unit/facet/table-facet-spec.ts
@@ -62,7 +62,7 @@ jest.mock('@/sheet-type', () => {
           clearHoverTimer: jest.fn(),
         },
         dataSet: {
-          isEmptyDataSet: jest.fn(),
+          isEmpty: jest.fn(),
         },
       };
     }),
@@ -82,7 +82,7 @@ jest.mock('@/data-set/table-data-set', () => {
         getCellData: () => 1,
         getFieldMeta: jest.fn(),
         getFieldFormatter: actualDataSet.prototype.getFieldFormatter,
-        isEmptyDataSet: jest.fn(),
+        isEmpty: jest.fn(),
       };
     }),
   };

diff --git a/packages/s2-core/src/data-set/base-data-set.ts b/packages/s2-core/src/data-set/base-data-set.ts
@@ -118,7 +118,7 @@ export abstract class BaseDataSet {
     return this.displayData;
   }
 
-  public isEmptyDataSet() {
+  public isEmpty() {
     return isEmpty(this.getDisplayDataSet());
   }
 

diff --git a/packages/s2-core/src/facet/table-facet.ts b/packages/s2-core/src/facet/table-facet.ts
@@ -1130,7 +1130,7 @@ export class TableFacet extends BaseFacet {
     }
 
     // https://github.com/antvis/S2/issues/2255
-    const indexes = this.spreadsheet.dataSet.isEmptyDataSet()
+    const indexes = this.spreadsheet.dataSet.isEmpty()
       ? ([] as unknown as Indexes)
       : calculateInViewIndexes(
           scrollX,

diff --git a/s2-site/docs/api/basic-class/base-data-set.zh.md b/s2-site/docs/api/basic-class/base-data-set.zh.md
@@ -28,7 +28,7 @@ s2.dataSet.getFieldName('type')
 | getCellData         | 获取单个的单元格数据               | (params: [CellDataParams](#celldataparams)) => [DataType[]](#datatype) |                                             |
 | getMultiData        | 获取批量的单元格数据               | (query: [DataType](#datatype), isTotals?: boolean, isRow?: boolean, drillDownFields?: string[]) => [DataType[]](#datatype) |                                             |
 | moreThanOneValue    | 是否超过 1 个数值                  | () => [ViewMeta](#viewmeta)                                  |                                             |
-| isEmptyDataSet    | 是否为空数据集                 | () => `boolean`                                 |      `@antv/s2-v1.51.1`                                       |
+| isEmpty    | 是否为空数据集                 | () => `boolean`                                 |      `@antv/s2-v1.51.1`                                       |
 
 ### DataType
-Original file line number
+Diff line change
@@ Expand Up / @@ -160,7 +160,7 @@ describe('Pivot Dataset Test', () => { @@
         });
         test('should get correctly empty dataset result', () => {
-          expect(dataSet.isEmptyDataSet()).toBeFalsy();
+          expect(dataSet.isEmpty()).toBeFalsy();
         });
       });
@@ Expand Down @@