refactor(ava/advisor): init new advisor pipeline & built-in modules to plugin-based architecture #784

chenluli · 2024-06-11T06:46:55Z

advisor pipeline 重构为插件式的结构：

Pipeline默认由4个阶段组成（数据处理, 图表类型推荐, 图表视觉通道映射, G2 spec 生成），每个阶段对应一个 Component 来处理
每个 component 的实际能力由 plugins 实现，通过自定义注册 plugins，实现自定义的对应环节的数据处理或推荐逻辑。每个 component 中的多个 plugins 并行执行，在 afterPluginsExecute hook 中处理多个插件的结果。
内部原函数改写为内置插件形式
期望通过这样的处理，可以解耦原 adise 函数，灵活选择性地使用和定制图表推荐的部分环节。该 PR 是第一部分，初始化整体框架，拆分出 encode 和 spec generate 环节见后续 PR： WIP: refactor(ava/advisor): separate visual encodingfrom spec generator module #785

refactor advisor pipeline:

split the default Pipeline into four stage: data analyze, chart type recommend, encode, spec generate. Each stage is processed by a Component
Component could have multiple plugins, these plugins are executed in parallel. The outputs of the plugins could be handled in afterPluginsExecute hook.
The original functions that for processing data, getting chart type spec and etc. are converted to preset plugins.

…folders

…o plugin-based architecture

packages/ava/src/advisor/advise-pipeline/plugin/presets/spec-generator/charts/area.ts

BBSQQ · 2024-06-19T02:43:36Z

site/examples/advice/advise-and-lint/demo/ca.jsx

+      dataProps,
+      data: filteredData,
+      chartTypeRecommendations: [{ chartType: 'pie_chart' }],
+    });


只看调用。看不出来 .dataAnalyzer 和 .specGenerator 和 adviceAsnyc 是 pipeline 的关系。对 execute 有疑惑 🤔

修改为不从 advisor 直接调用内部环节，而是从 pipeline 的方法上调用，每个 component 可以从 pipeline 上拿到并单独调用，如下示例：

// 单独使用 pipeline 中的部分环节 const dataAnalyzer = myChartAdvisor.pipeline.getComponent(PresetComponentName.dataAnalyzer) dataAnalyzer.execute({...}) // 之后增加 pipe 方法，dataAnalyzer.pipe(specGenerator).execute() ...

BBSQQ · 2024-06-19T02:51:48Z

packages/ava/src/advisor/types/pipeline.ts

+export type AdvisorPipelineContext = {
+  /** 原始数据 */
+  data?: Data;
+  advisor: Advisor;


pipeline 流转过程中 advisor 也是可选的？它一定有吗？

一定有的

BBSQQ · 2024-06-19T02:57:26Z

packages/ava/src/advisor/types/component.ts

+  type?: 'async' | 'sync';
+  execute: (data: Input, context: AdvisorPipelineContext) => Output | Promise<Output>;
+  /** 判断插件运行的条件 */
+  condition?: (data?: Input, context?: AdvisorPipelineContext) => boolean | Promise<boolean>;


data 也属于 ctx 是不是不用放第一个 args 呢？上面 exec 同理。

这里的 data 是各环节 component 自己的 input， context 里原来是整个 pipeline 开头的原始数据，不一样
这个问题可能和下面哪个 pipeline context 里是否加上 input 和 output 一起看

BBSQQ · 2024-06-19T06:06:27Z

packages/ava/src/advisor/advise-pipeline/plugin/presets/chart-type-recommend/get-chart-Type.ts

 }) => {
  const chatTypes = Object.keys(chartWIKI);
  const list: ScoringResultForChartType[] = chatTypes.map((chartType) => {
-    return scoreRules(chartType, chartWIKI, dataProps, ruleBase, options);
+    return scoreRules(chartType, chartWIKI, dataProps, ruleBase, options, advisorContext);


看到了个之前遗留的不统一的点：chartWIKI 是不是要小驼峰？

内部的函数我改了，但是之前有 validator 和 trigger 对外的 api 里有 chartWIKI，这个版本目前还不想产生不向下兼容的 break change... 所以对外接口里的还是先不改吧

BBSQQ · 2024-06-19T06:09:56Z

packages/ava/src/advisor/types/component.ts

+export type ChartTypeRecommendOutput = { chartTypeRecommendations: ScoringResultForChartType[] };
+
+export type SpecGeneratorInput = {
+  // todo 实际上不应该需要 score 信息


所以 score 是不是 for 中间结果评测的？

是的， score 模块不应该影响 spec 生成的环节，这个后面还要再拆

BBSQQ · 2024-06-19T06:12:09Z

packages/ava/src/advisor/types/component.ts

+export type PipelineStageType = 'dataAnalyze' | 'chartTypeRecommend' | 'encode' | 'specGenerate';
+
+/** 基础插件接口定义 */
+export interface AdvisorPluginType<Input = any, Output = any> {


我有一个大胆的想法，如果 advice pipeline 是确定的，有几个 component 也是确定的。这条 pipeline 是不是都属于一个 ctx，那这条链路上的 input 和 output 其实都是从当前的 ctx 中获得，而不用区分？也就是说这里的 Input 和 Output 其实都是 ctx。况且看下面 stage 还有多个的情况。

意思是说，pipeline context 里加上 input 和 output 属性么，这两个属性根据当前执行的环节进行更新？
每个环节的 input 和 output 可以挂到 ctx 上，不过前置环节的应该都需要挂上去，不能只挂当前环节的🤔️

每个 component 和 plugin 用类型约束，是想说用户在自定义自己的 plugin 时，能够明确需要的类型，都放 pipeline 感觉类型不好约束了？

BBSQQ · 2024-06-19T06:13:55Z

packages/ava/src/advisor/pipeline/pipeline.ts

+
+    components.forEach((component) => {
+      if (!component) return;
+      this.componentsManager.tapPromise(component.name, async (previousResult) => {


看起来 type?: 'async' | 'sync'; 并没有区分处理？

pipeline 这一层还没有区分，type?: 'async' | 'sync' 是 plugin 的定义，在 components 处理 plugin 执行时区分的。目前 pipeline 这一层抽象想的是串行执行各环节（里面的 components 只是个数组），暂不做编排工作？

BBSQQ · 2024-06-19T06:14:43Z

packages/ava/src/advisor/lint-pipeline/lintRules.ts

@@ -1,7 +1,7 @@
 import { Info, RuleModule } from '../ruler';

 import type { Specification } from '../../common/types';
-import type { ScoringResultForRule, Lint } from '../types';
+import type { ScoringResultForRule, Lint, AdvisorPipelineContext } from '../types';


lint 和 advice 现在的关系是什么样的？

lint 之前是在 spec generator 环节被内置调用的，保持原用法不变的话，它还是归属在 advise 的一环
另外，lint 也可看作一个独立的 pipeline，可以单独调用

BBSQQ · 2024-06-19T06:18:25Z

packages/ava/src/advisor/advisor.ts

+        pipelineComponent.registerPlugin(plugin);
+        return;
+      }
+      if (size(plugin.stage) === 1) {


所以当前还没有多 stage？

我先拿掉了 stage 的概念，plugin 挂到 component 上，各 component 直接在 pipeline 中串行执行，好像 stage 不是必须的🤔️

BBSQQ · 2024-06-19T06:22:28Z

packages/ava/src/advisor/advise-pipeline/plugin/presets/spec-generator/plugin-config.ts

+// todo 内置的 visualEncode 和 spec generate 插件需要明确支持哪些图表类型
+export const specGeneratorPlugin: AdvisorPluginType<SpecGeneratorInput, SpecGeneratorOutput> = {
+  name: 'defaultSpecGenerator',
+  stage: ['specGenerate'],


如果注册多个 plugin 作用于同一个 stage 它的表现会如何，顺序是怎么管理的？
问这个问题是看到下面操作生成 spec 其实也是有一个生成 or 操作顺序的，那么其实可以拆多个 plugin 实现，实现业务自定义 theme 之类的需求

之前想的是，一个 component 里的 plugin 都是并行的（输入和输出都被约束为一致的），所以没有声明它的执行顺序。
如果需要所说的有一个顺序执行的，感觉可以后续扩展 componet 的定义，如上面的框图所示， component 有点是执行管理器的概念，可以是用扩展定义其类型和嵌套来实现？

BBSQQ · 2024-06-19T06:27:00Z

packages/ava/src/advisor/advisor.ts

+
+  constructor(
+    config: AdvisorConfig = {},
+    custom: {


当前仅 constructor 输入 custom 不知道是否支持后续实例动态注册？

需要的，后续打算在 advisor 上增加 updateCkb, updateRuleBase, resigterComponents 等 api

BBSQQ · 2024-06-19T06:27:26Z

packages/ava/src/advisor/advisor.ts

+      /** extra info to pass through the pipeline
+       * 额外透传到推荐 pipeline 中的业务信息
+       */
+      extra?: Record<string, any>;


同理，extra 直接放 ctx 上？

是放在 context 上的，这里是 constructor 时进行初始化传参

BBSQQ · 2024-06-19T07:12:24Z

packages/ava/src/advisor/pipeline/component.ts

+      return Promise.resolve(this.execute(params));
+    }
+    const pluginsOutput = {};
+    return Promise.all(


promise.all 是并行执行的，上面的 forEach 是顺序调用的，不知道对结果有没有什么影响？🤔

上面是同步执行的，所以直接 forEach 了，这里异步不考虑顺序关系，如上评论，后续 component 若需要扩展出串行类型，再修改这里的执行逻辑

BBSQQ · 2024-06-19T07:16:47Z

packages/ava/src/advisor/advisor.ts

  }

+  private initDefaultComponents() {
+    this.dataAnalyzer = new BaseComponent('data', { plugins: [dataProcessorPlugin], context: this.context });
+    this.chartTypeRecommender = new BaseComponent('chartType', {


encode 和 generate 都是以动词结尾的，这个 chartType 是一整个名次，是不是叫 category 之类的包含 “分类” 含义好一些？

已修改，收在 enum PresetComponentName 下

/** 内置默认模块名 */ export enum PresetComponentName { dataAnalyzer, chartTypeRecommender, chartEncoder, specGenerator, }

…ents and pipeline

chenluli added 4 commits June 6, 2024 12:15

refactor(ava/advisor): split visual-encoder and chart-type-recommend …

a6af04d

…folders

refactor(ava/advisor): init new advisor pipeline & built-in modules t…

c35a204

…o plugin-based architecture

fix(ava/advisor): fix single datapoint line chart and area chart

a86960e

fix(ava/advisor): add advisor export types

3d32447

chenluli force-pushed the dev-refactor-pipeline1 branch 2 times, most recently from 6b28516 to 716ab18 Compare June 17, 2024 08:19

feat(ava/advisor): add async and condition type to advisor plugin

85cc0ce

chenluli force-pushed the dev-refactor-pipeline1 branch from 716ab18 to 85cc0ce Compare June 17, 2024 08:59

chenluli changed the title ~~WIP: refactor(ava/advisor): init new advisor pipeline & built-in modules to plugin-based architecture~~ refactor(ava/advisor): init new advisor pipeline & built-in modules to plugin-based architecture Jun 17, 2024

chenluli mentioned this pull request Jun 17, 2024

WIP: refactor(ava/advisor): separate visual encodingfrom spec generator module #785

Draft

3 tasks

chenluli requested review from BBSQQ, Yzing and hustcc June 17, 2024 09:32

chenluli commented Jun 19, 2024

View reviewed changes

packages/ava/src/advisor/advise-pipeline/plugin/presets/spec-generator/charts/area.ts Show resolved Hide resolved

BBSQQ reviewed Jun 19, 2024

View reviewed changes

refactor(ava/advisor): adjustments to the concepts and APIs of compon…

70b5899

…ents and pipeline

chenluli marked this pull request as ready for review July 8, 2024 11:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(ava/advisor): init new advisor pipeline & built-in modules to plugin-based architecture #784

refactor(ava/advisor): init new advisor pipeline & built-in modules to plugin-based architecture #784

chenluli commented Jun 11, 2024 •

edited

Loading

BBSQQ Jun 19, 2024

chenluli Jul 8, 2024

BBSQQ Jun 19, 2024

chenluli Jul 8, 2024

BBSQQ Jun 19, 2024

chenluli Jul 8, 2024

BBSQQ Jun 19, 2024

chenluli Jul 8, 2024

BBSQQ Jun 19, 2024

chenluli Jul 8, 2024

BBSQQ Jun 19, 2024

chenluli Jul 8, 2024 •

edited

Loading

BBSQQ Jun 19, 2024

chenluli Jul 8, 2024

BBSQQ Jun 19, 2024

chenluli Jul 8, 2024

BBSQQ Jun 19, 2024

chenluli Jul 8, 2024

BBSQQ Jun 19, 2024

chenluli Jul 8, 2024

BBSQQ Jun 19, 2024

chenluli Jul 8, 2024

BBSQQ Jun 19, 2024

chenluli Jul 8, 2024

BBSQQ Jun 19, 2024

chenluli Jul 8, 2024

BBSQQ Jun 19, 2024

chenluli Jul 8, 2024

refactor(ava/advisor): init new advisor pipeline & built-in modules to plugin-based architecture #784

Are you sure you want to change the base?

refactor(ava/advisor): init new advisor pipeline & built-in modules to plugin-based architecture #784

Conversation

chenluli commented Jun 11, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chenluli Jul 8, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chenluli commented Jun 11, 2024 •

edited

Loading

chenluli Jul 8, 2024 •

edited

Loading