Skip processing Service without IPPool annotation #6950
+24
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoninbas
reviewed
Jan 23, 2025
Comment on lines
159
to
162
| _, allocationExists := c.getExternalIPAllocation(namespacedName) | ||
| if !allocationExists && getServiceExternalIPPool(service) == "" { | ||
| return | ||
| } |
There was a problem hiding this comment.
could there be a race condition with a concurrent call to syncService operating on a previous version of the Service?
enqueueService(this function) observes no current allocation (allocationExistsis false) and no annotation (getServiceExternalIPPool(service)is the empty string)syncServiceobserves a previous version of the Service with the annotation, and is in the process of creating an allocation.
@tnqn do you know if it is safe to have a stateful check in this code path (event handler function)?
There was a problem hiding this comment.
updated the checks for annotations to ResourceEventHandlerFuncs before enqueueService as it is not needed to check the IP allocations.
xliuxu
force-pushed
the
xliuxu/service-external-ip-queue
branch
from
6ef2d70 to
c12b4dd
Compare
Signed-off-by: Xu Liu <[email protected]>
xliuxu
force-pushed
the
xliuxu/service-external-ip-queue
branch
from
c12b4dd to
49276de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.