Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Windows] Support OF port state "down" when installing Pod forwarding rules #6889

Merged
merged 1 commit into from
Dec 31, 2024
Merged

[Windows] Support OF port state "down" when installing Pod forwarding rules #6889

merged 1 commit into from
Dec 31, 2024

Conversation

wenyingd
Copy link
Contributor

@wenyingd wenyingd commented Dec 30, 2024 •
edited
Loading

On Windows, OVS has an issue which doesn't correctly update the port status after an OpenFlow port is successfully installed. So OVS may send out PortStatus message with Port state as LINK_DOWN, this issue doesn't impact on the datapath forwarding.

This change is a workaround to ensure Pod's OpenFlow entries are installed as long as the OpenFlow port is allocated.

Fix: #6888

@wenyingd
Copy link
Contributor Author

/test-all
/test-windows-all

@luolanzone
Copy link
Contributor

/test-windows-all

@wenyingd wenyingd changed the title [Windows] Support OF port state "blocked" when installing Pod forwarding rules [Windows] Support OF port state "down" when installing Pod forwarding rules Dec 30, 2024
@wenyingd
Copy link
Contributor Author

/test-all
/test-windows-all

@luolanzone luolanzone added area/OS/windows Issues or PRs related to the Windows operating system. kind/bug Categorizes issue or PR as related to a bug. labels Dec 30, 2024
@wenyingd wenyingd requested a review from luolanzone December 30, 2024 08:41
tnqn
tnqn reviewed Dec 30, 2024
View reviewed changes
pkg/agent/cniserver/pod_configuration.go Outdated Show resolved Hide resolved
pkg/agent/cniserver/pod_configuration.go Outdated Show resolved Hide resolved
@wenyingd wenyingd requested a review from tnqn December 30, 2024 09:07
@wenyingd
Copy link
Contributor Author

/test-all
/test-windows-all

@wenyingd
[Windows] Support OF port state "down" when installing Pod forwarding…
859ff98 
… rules

On Windows, OVS has an issue which doesn't correctly update the port status
after an OpenFlow port is successfully installed. So OVS may send out PortStatus
message with Port state as LIND_DOWN, this issue doesn't impact on the datapath
forwarding.

This change is a workaround to ensure Pod's OpenFlow entries are installed as
long as the OpenFlow port is allocated.

Signed-off-by: Wenying Dong <[email protected]>
tnqn
tnqn approved these changes Dec 30, 2024
View reviewed changes
Copy link
Member

@tnqn tnqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenyingd
Copy link
Contributor Author

/test-all
/test-windows-all

@luolanzone
Copy link
Contributor

/test-windows-all

luolanzone
luolanzone approved these changes Dec 30, 2024
View reviewed changes
Copy link
Contributor

@luolanzone luolanzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix.

@luolanzone
Copy link
Contributor

/test-windows-e2e
/test-windows-conformance

1 similar comment
@luolanzone
Copy link
Contributor

/test-windows-e2e
/test-windows-conformance

@luolanzone
Copy link
Contributor

/test-windows-all

@wenyingd
Copy link
Contributor Author

/test-windows-conformance

@wenyingd
Copy link
Contributor Author

wenyingd commented Dec 31, 2024 •
edited
Loading

The Windows e2e failure is because a "coredns" Pod desired in the test case is not running as expected, which fails because the required image docker.io/coredns/coredns:1.11.3 only supports running on Linux, while the case was trying to run the Pod on a Windows Node. So it is a test case issue #6891.

The Windows conformance test is failed with case Service endpoints latency [It] should not be very high [Conformance], which is because the required image "registry.k8s.io/e2e-test-images/pause:3.10" was not pulled on Windows, and from CI test logs http://10.164.243.223/view/Windows/job/antrea-windows-conformance-for-pull-request/56/console we observed that the image was failed to pull because of the testbed's Node's X509 certificate issues.

@tnqn tnqn merged commit 531d61f into antrea-io:main Dec 31, 2024
60 of 62 checks passed
wenyingd added a commit to wenyingd/antrea that referenced this pull request Dec 31, 2024
@wenyingd
Support OF port state "down" when installing Pod forwarding rules (an…
31881ce 
…trea-io#6889)

On Windows, OVS has an issue which doesn't correctly update the port status
after an OpenFlow port is successfully installed. So OVS may send out PortStatus
message with Port state as LIND_DOWN, this issue doesn't impact on the datapath
forwarding.

This change is a workaround to ensure Pod's OpenFlow entries are installed as
long as the OpenFlow port is allocated.

Signed-off-by: Wenying Dong <[email protected]>
@wenyingd wenyingd mentioned this pull request Dec 31, 2024
Merged
luolanzone pushed a commit that referenced this pull request Jan 3, 2025
@wenyingd
Support OF port state "down" when installing Pod forwarding rules (#6889
d737ff8 
) (#6893)

On Windows, OVS has an issue which doesn't correctly update the port status
after an OpenFlow port is successfully installed. So OVS may send out PortStatus
message with Port state as LIND_DOWN, this issue doesn't impact on the datapath
forwarding.

This change is a workaround to ensure Pod's OpenFlow entries are installed as
long as the OpenFlow port is allocated.

Signed-off-by: Wenying Dong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luolanzone luolanzone luolanzone approved these changes

@tnqn tnqn tnqn approved these changes

@antoninbas antoninbas Awaiting requested review from antoninbas

@XinShuYang XinShuYang Awaiting requested review from XinShuYang

Assignees
No one assigned
Labels
area/OS/windows Issues or PRs related to the Windows operating system. kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows Pod fails to configure OpenFlow entries
3 participants
@wenyingd @luolanzone @tnqn