Support antctl command for packetcapture #6884
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| func untarAll(reader io.Reader) error { | ||
| tarReader := tar.NewReader(reader) | ||
| for { | ||
| header, err := tarReader.Next() |
Check failure
Code scanning / CodeQL
Arbitrary file access during archive extraction ("Zip Slip") High
There was a problem hiding this comment.
after #3659 is merged, this should be fixed.
Signed-off-by: Hang Yan <[email protected]>
hangyan
force-pushed
the
topic/yhang/packetcapture-antctl
branch
from
4a616d6 to
bf4cb68
Compare
Signed-off-by: Hang Yan <[email protected]>
| func untarAll(reader io.Reader, dstDir string) error { | ||
| tarReader := tar.NewReader(reader) | ||
| for { | ||
| header, err := tarReader.Next() |
Check failure
Code scanning / CodeQL
Arbitrary file access during archive extraction ("Zip Slip") High
Signed-off-by: Hang Yan <[email protected]>
hangyan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO items:
after #3659 , the CodeQL alert should be fixed and UT coverage will also be improved.