Add `antctl check installation` command to conduct connectivity checks (#6133) #6133

kanha-gupta · 2024-03-22T02:30:27Z

Ref #6061
This PR introduces new tests for Antrea (Post installation connectivity tests) using antctl test command. Following are the functionalities :

Framework to conduct connectivity tests is created
Currently supports Pod to pod connectivity tests within same nodes, different nodes
Also supports testing internet connectivity

Github workflow is also updated accordingly

Signed-off-by: Kanha gupta <[email protected]> Enable Post installation Connectivity tests Signed-off-by: Kanha gupta <[email protected]> Enable Post installation Connectivity tests Signed-off-by: Kanha gupta <[email protected]> Enable Post installation Connectivity tests Signed-off-by: Kanha gupta <[email protected]> Enable Post installation Connectivity tests Signed-off-by: Kanha gupta <[email protected]> Enable Post installation Connectivity tests Signed-off-by: Kanha gupta <[email protected]> Pod to pod working, same and different nodes and Internet connectivity

…ests Signed-off-by: Kanha gupta <[email protected]>

antoninbas

some initial comments

.github/workflows/kind.yml

pkg/antctl/raw/test/client.go

pkg/antctl/raw/test/command.go

Signed-off-by: Kanha gupta <[email protected]> Initial review changes Signed-off-by: Kanha gupta <[email protected]>

kanha-gupta · 2024-03-23T21:47:33Z

Hi @antoninbas Thank you for the review. I have made changes and it is visible in the new commit I've made.
Thank you

pkg/antctl/raw/test/command.go

Signed-off-by: Kanha gupta <[email protected]>

kanha-gupta · 2024-03-26T11:36:35Z

@antoninbas Thanks for the review, I have made all the changes and The examples of randomly generated namespace output is "antrea-test-gst75", "antrea-test-i9ubk" etc.
Thank you

pkg/antctl/antctl.go

pkg/antctl/raw/test/client.go

pkg/antctl/raw/test/command.go

pkg/antctl/raw/test/exec.go

antoninbas

Having think about it some more, I think the command could look like this: antctl check installation. When you address #6153, you should use the same command group (antctl check), and maybe that command should be antctl check pre-installation or antctl check cluster.

pkg/antctl/raw/test/command.go

pkg/antctl/antctl.go

pkg/antctl/raw/test/command.go

kanha-gupta · 2024-03-27T21:31:07Z

Hi mentors, Thanks for the review and I've made changes and It is visible in the new commit I've made.
The raw/test directory contains go files directly at this point and I wanted to know if its a good practice to refactor the structure in this PR only or refactor it while adding support for preinstallation checks since its go files will need separation under raw/test directory
Thank you

Signed-off-by: Kanha gupta <[email protected]>

.github/workflows/kind.yml

pkg/antctl/antctl.go

pkg/antctl/raw/test/client.go

pkg/antctl/raw/test/command.go

pkg/antctl/raw/test/client.go

pkg/antctl/raw/test/command.go

Signed-off-by: Kanha gupta <[email protected]>

kanha-gupta · 2024-04-04T12:09:14Z

Hey mentors, I have did all the changes.
Test files are yet to be implemented in this PR and I will implement it after the framework is finalised so as to prevent confusion.
Thank you

pkg/antctl/raw/check/client.go

pkg/antctl/raw/check/installation/command.go

pkg/antctl/raw/check/installation/test_PodToInternet.go

.github/workflows/kind.yml

kanha-gupta · 2024-04-11T23:30:44Z

Hey mentors, I have made the changes in latest commit. Please review :)

Signed-off-by: Kanha gupta <[email protected]>

pkg/antctl/raw/check/client.go

pkg/antctl/raw/check/installation/command.go

Signed-off-by: Kanha gupta <[email protected]>

pkg/antctl/raw/check/installation/command.go

pkg/antctl/raw/check/installation/test_podtopod.go

pkg/antctl/raw/check/installation/command.go

pkg/antctl/raw/check/installation/test_podtointernet.go

kanha-gupta · 2024-04-23T11:40:32Z

Hey mentors, changes have been pushed in the latest commit :)

pkg/antctl/raw/check/installation/command.go

pkg/antctl/raw/check/installation/test_podtointernet.go

Signed-off-by: Kanha gupta <[email protected]>

kanha-gupta · 2024-04-23T21:17:14Z

Hey mentors, Changes have been pushed in the commit :)

pkg/antctl/raw/check/installation/command.go

kanha-gupta · 2024-04-24T05:34:10Z

Hey mentors, changes have been pushed :)

pkg/antctl/raw/check/installation/command.go

.github/workflows/kind.yml

pkg/antctl/raw/check/installation/command.go

pkg/antctl/raw/check/installation/test_podtointernet.go

pkg/antctl/raw/check/installation/test_podtopodinternode.go

pkg/antctl/raw/check/installation/test_podtopodintranode.go

Signed-off-by: Kanha gupta <[email protected]>

kanha-gupta · 2024-04-24T11:02:53Z

Hey mentors, changes have been pushed.
There are 2 comments left to discuss from previous review
Thank you :)

pkg/antctl/raw/check/installation/test_podtopodinternode.go

pkg/antctl/raw/check/installation/test_podtointernet.go

pkg/antctl/raw/check/installation/test_podtopodinternode.go

.github/workflows/kind.yml

pkg/antctl/raw/check/installation/test_podtopodintranode.go

Signed-off-by: Kanha gupta <[email protected]>

kanha-gupta · 2024-04-24T21:16:02Z

Hey mentors, Changes are pushed :)

antoninbas

LGTM, @tnqn @luolanzone do you want to take another look?

tnqn

LGTM

Tested in a cluster which I was reproducing service issue, connecting to google.com failed as expected, but it should be related to DNS, maybe we could differentiate Connection timeout and DNS resolution timeout later.

[kind-kind] Test starting....
[kind-kind] Creating Namespace antrea-test-729be for post installation tests...
[kind-kind] Deploying echo-same-node Service echo-same-node...
[kind-kind] Deploying client Deployment test-client...
[kind-kind] Deploying echo-other-node Service echo-other-node...
[kind-kind] Waiting for Deployment test-client to become ready...
[kind-kind] Deployment test-client is ready.
[kind-kind] Waiting for Deployment echo-same-node to become ready...
[kind-kind] Deployment echo-same-node is ready.
[kind-kind] Waiting for Deployment echo-other-node to become ready...
[kind-kind] Deployment echo-other-node is ready.
[kind-kind] Deployment is validated successfully
[kind-kind] -------------------------------------------------------------------------------------------
[kind-kind] Running test: pod-to-pod-internode-connectivity
[kind-kind] -------------------------------------------------------------------------------------------
[kind-kind] Validating from Pod antrea-test-729be/test-client-5448f7d5f6-dplnl to Pod antrea-test-729be/echo-other-node-64c4f7664-csrw8 at IP 10.244.2.4...
[kind-kind] client Pod test-client-5448f7d5f6-dplnl was able to communicate with echo Pod echo-other-node-64c4f7664-csrw8 (10.244.2.4)
[kind-kind] -------------------------------------------------------------------------------------------
[kind-kind] Test pod-to-pod-internode-connectivity passed
[kind-kind] -------------------------------------------------------------------------------------------
[kind-kind] -------------------------------------------------------------------------------------------
[kind-kind] Running test: pod-to-pod-intranode-connectivity
[kind-kind] -------------------------------------------------------------------------------------------
[kind-kind] Validating from Pod antrea-test-729be/test-client-5448f7d5f6-dplnl to Pod antrea-test-729be/echo-same-node-67dfc97d4b-wdqwh at IP 10.244.1.3...
[kind-kind] client Pod test-client-5448f7d5f6-dplnl was able to communicate with echo Pod echo-same-node-67dfc97d4b-wdqwh (10.244.1.3)
[kind-kind] -------------------------------------------------------------------------------------------
[kind-kind] Test pod-to-pod-intranode-connectivity passed
[kind-kind] -------------------------------------------------------------------------------------------
[kind-kind] -------------------------------------------------------------------------------------------
[kind-kind] Running test: pod-to-internet-connectivity
[kind-kind] -------------------------------------------------------------------------------------------
[kind-kind] Validating connectivity from Pod antrea-test-729be/test-client-5448f7d5f6-dplnl to the world (google.com)...
[kind-kind] -------------------------------------------------------------------------------------------
[kind-kind] Test pod-to-internet-connectivity failed: Pod antrea-test-729be/test-client-5448f7d5f6-dplnl was not able to connect to google.com: error in stream: command terminated with exit code 1
[kind-kind] -------------------------------------------------------------------------------------------
[kind-kind] Test finished
[kind-kind] Deleting post installation tests setup...
[kind-kind] Waiting for Namespace antrea-test-729be to disappear
[kind-kind] Setup deletion successful

antoninbas · 2024-04-25T16:57:10Z

/skip-all

antoninbas · 2024-04-29T17:58:52Z

Thanks for your contribution to Antrea @kanha-gupta !

kanha-gupta · 2024-04-29T19:59:15Z

Thanks for your contribution to Antrea @kanha-gupta !

Thanks to all of you for the guidance :)

kanha-gupta added 3 commits March 21, 2024 13:14

Merge branch 'main' into antrea-connectivity-tests

8d93f94

Add antctl test command to conduct post installation connectivity t…

6c238fe

…ests Signed-off-by: Kanha gupta <[email protected]>

antoninbas requested review from antoninbas, tnqn and luolanzone March 22, 2024 19:22

antoninbas reviewed Mar 22, 2024

View reviewed changes

Initial review changes

2a26ae3

Signed-off-by: Kanha gupta <[email protected]> Initial review changes Signed-off-by: Kanha gupta <[email protected]>

antoninbas reviewed Mar 26, 2024

View reviewed changes

review 2 changes

e39d1ff

Signed-off-by: Kanha gupta <[email protected]>

tnqn reviewed Mar 26, 2024

View reviewed changes

antoninbas reviewed Mar 27, 2024

View reviewed changes

pkg/antctl/raw/test/command.go Outdated Show resolved Hide resolved

pkg/antctl/antctl.go Outdated Show resolved Hide resolved

pkg/antctl/raw/test/command.go Outdated Show resolved Hide resolved

kanha-gupta force-pushed the antrea-connectivity-tests branch from ffdae6c to 9a103cc Compare March 27, 2024 21:26

review 3 changes

75aff65

Signed-off-by: Kanha gupta <[email protected]>

kanha-gupta force-pushed the antrea-connectivity-tests branch from 9a103cc to 75aff65 Compare March 28, 2024 05:29

luolanzone reviewed Mar 29, 2024

View reviewed changes

tnqn reviewed Apr 3, 2024

View reviewed changes

Review 4 changes

1da8ca3

Signed-off-by: Kanha gupta <[email protected]>

tnqn reviewed Apr 9, 2024

View reviewed changes

antoninbas reviewed Apr 10, 2024

View reviewed changes

.github/workflows/kind.yml Outdated Show resolved Hide resolved

kanha-gupta force-pushed the antrea-connectivity-tests branch from eb04d42 to ef850b9 Compare April 11, 2024 23:39

Review 5 changes

f9bae30

Signed-off-by: Kanha gupta <[email protected]>

kanha-gupta force-pushed the antrea-connectivity-tests branch from ef850b9 to f9bae30 Compare April 15, 2024 23:14

tnqn reviewed Apr 16, 2024

View reviewed changes

review 6 changes

d8ece9f

Signed-off-by: Kanha gupta <[email protected]>

antoninbas reviewed Apr 19, 2024

View reviewed changes

tnqn reviewed Apr 19, 2024

View reviewed changes

pkg/antctl/raw/check/installation/command.go Show resolved Hide resolved

pkg/antctl/raw/check/installation/command.go Outdated Show resolved Hide resolved

pkg/antctl/raw/check/installation/test_podtointernet.go Outdated Show resolved Hide resolved

tnqn reviewed Apr 23, 2024

View reviewed changes

pkg/antctl/raw/check/installation/command.go Outdated Show resolved Hide resolved

pkg/antctl/raw/check/installation/command.go Outdated Show resolved Hide resolved

pkg/antctl/raw/check/installation/test_podtointernet.go Outdated Show resolved Hide resolved

antoninbas added this to the Antrea v2.1 release milestone Apr 23, 2024

antoninbas mentioned this pull request Apr 23, 2024

Add antctl CLI command to run post-installation checks #6061

Closed

review 7 changes

130283a

Signed-off-by: Kanha gupta <[email protected]>

kanha-gupta force-pushed the antrea-connectivity-tests branch from be96ade to 130283a Compare April 23, 2024 21:15

antoninbas reviewed Apr 23, 2024

View reviewed changes

luolanzone reviewed Apr 24, 2024

View reviewed changes

review 8 changes

78dab63

Signed-off-by: Kanha gupta <[email protected]>

kanha-gupta force-pushed the antrea-connectivity-tests branch from 6e8bf14 to 78dab63 Compare April 24, 2024 10:59

antoninbas reviewed Apr 24, 2024

View reviewed changes

Support for IPv6 & Dual Stack

9f244e3

Signed-off-by: Kanha gupta <[email protected]>

antoninbas approved these changes Apr 24, 2024

View reviewed changes

tnqn approved these changes Apr 25, 2024

View reviewed changes

antoninbas merged commit dc97a83 into antrea-io:main Apr 29, 2024
49 of 53 checks passed

antoninbas changed the title ~~Add antctl test command to conduct post installation connectivity tests~~ Add antctl check installation command to conduct connectivity checks (#6133) Apr 29, 2024

kanha-gupta deleted the antrea-connectivity-tests branch April 29, 2024 19:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `antctl check installation` command to conduct connectivity checks (#6133) #6133

Add `antctl check installation` command to conduct connectivity checks (#6133) #6133

kanha-gupta commented Mar 22, 2024 •

edited

Loading

antoninbas left a comment

kanha-gupta commented Mar 23, 2024

kanha-gupta commented Mar 26, 2024

antoninbas left a comment

kanha-gupta commented Mar 27, 2024 •

edited

Loading

kanha-gupta commented Apr 4, 2024

kanha-gupta commented Apr 11, 2024

kanha-gupta commented Apr 23, 2024

kanha-gupta commented Apr 23, 2024

kanha-gupta commented Apr 24, 2024

kanha-gupta commented Apr 24, 2024

kanha-gupta commented Apr 24, 2024

antoninbas left a comment

tnqn left a comment

antoninbas commented Apr 25, 2024

antoninbas commented Apr 29, 2024

kanha-gupta commented Apr 29, 2024

Add antctl check installation command to conduct connectivity checks (#6133) #6133

Add antctl check installation command to conduct connectivity checks (#6133) #6133

Conversation

kanha-gupta commented Mar 22, 2024 • edited Loading

antoninbas left a comment

Choose a reason for hiding this comment

kanha-gupta commented Mar 23, 2024

kanha-gupta commented Mar 26, 2024

antoninbas left a comment

Choose a reason for hiding this comment

kanha-gupta commented Mar 27, 2024 • edited Loading

kanha-gupta commented Apr 4, 2024

kanha-gupta commented Apr 11, 2024

kanha-gupta commented Apr 23, 2024

kanha-gupta commented Apr 23, 2024

kanha-gupta commented Apr 24, 2024

kanha-gupta commented Apr 24, 2024

kanha-gupta commented Apr 24, 2024

antoninbas left a comment

Choose a reason for hiding this comment

tnqn left a comment

Choose a reason for hiding this comment

antoninbas commented Apr 25, 2024

antoninbas commented Apr 29, 2024

kanha-gupta commented Apr 29, 2024

Add `antctl check installation` command to conduct connectivity checks (#6133) #6133

Add `antctl check installation` command to conduct connectivity checks (#6133) #6133

kanha-gupta commented Mar 22, 2024 •

edited

Loading

kanha-gupta commented Mar 27, 2024 •

edited

Loading