4.2.3

CHANGELOG.md

@@ -1,10 +1,14 @@
 # Changelog
 
-## [Unreleased]
+## [4.2.3] - 2022-02-20
 
 ### Changed
 
-- Keep retrying assets upload even if `422/UnprocessableEntity`/`502/BadGateway` is encountered and asset was not found on the partially created release (this will make git-release more robust to unexpected API responses)
+- Keep retrying assets upload even if `422/UnprocessableEntity`/`502/BadGateway` is encountered and asset was not found on the partially created release
+
+### Fixed
+
+- [Issue #64](https://github.com/anton-yurchenko/git-release/issues/64) Panic on missing API response (*Thanks to [rgriebl](https://github.com/rgriebl)*)
 
 ## [4.2.2] - 2022-02-05
 
@@ -334,7 +338,7 @@ This is a major release as most of the code was refactored and some behavior was
 - Control Release Draft through env.var 'DRAFT_RELEASE'
 - Control Release Pre Release through env.var 'PRE_RELEASE'
 
-[Unreleased]: https://github.com/anton-yurchenko/git-release/compare/v4.2.2...HEAD
+[4.2.3]: https://github.com/anton-yurchenko/git-release/compare/v4.2.2...v4.2.3
 [4.2.2]: https://github.com/anton-yurchenko/git-release/compare/v4.2.1...v4.2.2
 [4.2.1]: https://github.com/anton-yurchenko/git-release/compare/v4.2.0...v4.2.1
 [4.2.0]: https://github.com/anton-yurchenko/git-release/compare/v4.1.2...v4.2.0

Dockerfile

@@ -7,7 +7,7 @@ RUN CGO_ENABLED=0 go build -ldflags="-w -s" -o /opt/app
 
 FROM scratch
 LABEL org.opencontainers.image.source="https://github.com/anton-yurchenko/git-release"
-LABEL org.opencontainers.image.version="v4.2.2"
+LABEL org.opencontainers.image.version="v4.2.3"
 LABEL org.opencontainers.image.authors="Anton Yurchenko <[email protected]>"
 LABEL org.opencontainers.image.licenses="MIT"
 COPY --from=builder /etc/ssl/certs/ca-certificates.crt /etc/ssl/certs/

main.go

@@ -14,7 +14,7 @@ import (
 )
 
 // Version contains current application version
-const Version string = "4.2.2"
+const Version string = "4.2.3"
 
 func init() {
 	log.SetReportCaller(false)

package.json

@@ -1,6 +1,6 @@
 {
   "name": "git-release",
-  "version": "4.2.2",
+  "version": "4.2.3",
   "description": "A GitHub Action for creating a GitHub Release with Assets and Changelog whenever a new Tag is pushed to the repository.",
   "main": "wrapper.js",
   "directories": {

release/asset.go

@@ -113,34 +113,38 @@ func (a *Asset) uploadHandler(release *Release, cli RepositoriesClient, id int64
 	if err != nil {
 		log.WithField("asset", a.Name).Warnf("error uploading asset: %v", err.Error())
 
-		if !lastTry && (res.StatusCode == http.StatusBadGateway || res.StatusCode == http.StatusUnprocessableEntity) {
-			rel, _, err := cli.GetReleaseByTag(
-				context.Background(),
-				release.Slug.Owner,
-				release.Slug.Name,
-				release.Reference.Tag,
-			)
-			if err != nil {
-				return errors.Wrap(err, "error retrieving release")
-			}
+		if !lastTry && res.Response != nil {
+			if res.StatusCode == http.StatusBadGateway || res.StatusCode == http.StatusUnprocessableEntity {
+				rel, _, err := cli.GetReleaseByTag(
+					context.Background(),
+					release.Slug.Owner,
+					release.Slug.Name,
+					release.Reference.Tag,
+				)
+				if err != nil {
+					return errors.Wrap(err, "error retrieving release")
+				}
 
-			for _, s := range rel.Assets {
-				if *s.Name == strings.ReplaceAll(a.Name, "/", "-") {
-					_, err = cli.DeleteReleaseAsset(
-						context.Background(),
-						release.Slug.Owner,
-						release.Slug.Name,
-						*s.ID,
-					)
-					if err != nil {
-						return errors.Wrap(err, "error deleting ghost release asset")
+				for _, s := range rel.Assets {
+					if *s.Name == strings.ReplaceAll(a.Name, "/", "-") {
+						_, err = cli.DeleteReleaseAsset(
+							context.Background(),
+							release.Slug.Owner,
+							release.Slug.Name,
+							*s.ID,
+						)
+						if err != nil {
+							return errors.Wrap(err, "error deleting ghost release asset")
+						}
+
+						return errors.New("ghost release asset deleted")
 					}
-
-					return errors.New("ghost release asset deleted")
 				}
+
+				return errors.New("ghost release asset not found")
 			}
 
-			return errors.New("ghost release asset not found")
+			log.WithField("asset", a.Name).Debugf("received unexpected http response code during asset upload: %v", res.StatusCode)
 		}
 
 		return err

release/asset_test.go

@@ -494,6 +494,39 @@ func TestUpload(t *testing.T) {
 				Error: "",
 			},
 		},
+		"No API Response [long test]": {
+			Asset: release.Asset{
+				Name: "test/File1",
+				Path: "testFile1",
+			},
+			Release: &release.Release{
+				Slug: &release.Slug{
+					Owner: "anton-yurchenko",
+					Name:  "git-release",
+				},
+				Reference: &release.Reference{
+					Tag: "v1.0.0",
+				},
+			},
+			MockResponses: []mockResponses{
+				{
+					UploadReleaseAssetResponse: &github.Response{
+						Response: nil,
+					},
+					UploadReleaseAssetError: errors.New("reason-a"),
+				},
+				{
+					LastTry: true,
+					UploadReleaseAssetResponse: &github.Response{
+						Response: &http.Response{StatusCode: http.StatusOK},
+					},
+					UploadReleaseAssetError: nil,
+				},
+			},
+			Expected: expected{
+				Error: "",
+			},
+		},
 		"File Does Not Exists": {
 			Asset: release.Asset{
 				Name: "testFile3",
@@ -543,30 +576,32 @@ func TestUpload(t *testing.T) {
 				mock.AnythingOfType("*os.File"),
 			).Return(nil, res.UploadReleaseAssetResponse, res.UploadReleaseAssetError).Once()
 
-			if !res.LastTry && (res.UploadReleaseAssetResponse.StatusCode == http.StatusBadGateway || res.UploadReleaseAssetResponse.StatusCode == http.StatusUnprocessableEntity) {
-				m.On("GetReleaseByTag",
-					context.Background(),
-					test.Release.Slug.Owner,
-					test.Release.Slug.Name,
-					test.Release.Reference.Tag,
-				).Return(res.GetReleaseByTagRelease, nil, res.GetReleaseByTagError).Once()
-
-				if res.GetReleaseByTagError == nil {
-					var assetID int64
-					for _, s := range res.GetReleaseByTagRelease.Assets {
-						if *s.Name == strings.ReplaceAll(test.Asset.Name, "/", "-") {
-							assetID = *s.ID
-							break
+			if !res.LastTry && res.UploadReleaseAssetResponse.Response != nil {
+				if res.UploadReleaseAssetResponse.StatusCode == http.StatusBadGateway || res.UploadReleaseAssetResponse.StatusCode == http.StatusUnprocessableEntity {
+					m.On("GetReleaseByTag",
+						context.Background(),
+						test.Release.Slug.Owner,
+						test.Release.Slug.Name,
+						test.Release.Reference.Tag,
+					).Return(res.GetReleaseByTagRelease, nil, res.GetReleaseByTagError).Once()
+
+					if res.GetReleaseByTagError == nil {
+						var assetID int64
+						for _, s := range res.GetReleaseByTagRelease.Assets {
+							if *s.Name == strings.ReplaceAll(test.Asset.Name, "/", "-") {
+								assetID = *s.ID
+								break
+							}
 						}
-					}
 
-					if res.GetReleaseByTagError == nil && assetID != 0 {
-						m.On("DeleteReleaseAsset",
-							context.Background(),
-							test.Release.Slug.Owner,
-							test.Release.Slug.Name,
-							assetID,
-						).Return(nil, res.DeleteReleaseAssetError).Once()
+						if res.GetReleaseByTagError == nil && assetID != 0 {
+							m.On("DeleteReleaseAsset",
+								context.Background(),
+								test.Release.Slug.Owner,
+								test.Release.Slug.Name,
+								assetID,
+							).Return(nil, res.DeleteReleaseAssetError).Once()
+						}
 					}
 				}
 			}