Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- Solve issues #9 and #23. #24

Merged
merged 1 commit into from
May 9, 2020
Merged

- Solve issues #9 and #23. #24

merged 1 commit into from
May 9, 2020

Conversation

gilcesarf
Copy link
Contributor

This PR adds capability of showing parsing errors through maven log output when verbose option is true, solving issue #23 .

It also adds basic documentation about .errors and .tree files, solving issue #9 .

Finally, unit tests on AssertErrorsErrorListener class are improved by checking conditions with .errors files and by adding easymock 3.6 to support those checks. Easymock 4.2 was also tried, but due to java version incompatibilities and no advanced testing features necessity, the downgrade was made.

@teverett
Copy link
Member

teverett commented May 9, 2020

@gilcesarf thanks. Do you have more changes coming, or is now a good time to make a release build?

@teverett teverett merged commit 96b52fc into antlr:master May 9, 2020
@gilcesarf
Copy link
Contributor Author

I have no more intended changes in the short term now.

@teverett
Copy link
Member

teverett commented May 9, 2020

Thank-you again for your contributions

@gilcesarf
Copy link
Contributor Author

You are welcome... Let me know when you generate a new release so I can close the issues I had opened...

teverett added a commit that referenced this pull request Aug 6, 2021
…exus-plexus-utils-3.4.0

Bump plexus-utils from 3.3.0 to 3.4.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants