Rename offset to index to better capture its meaning #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the name "offset" to "index" to capture its intended purpose: Copying data into regions yields indexes, which the index structures can absorb. Some of the indexes might be offsets, but that's only known to the region, but no the user of the region. For the user of a region, the index is an opaque handle to retrieve semantically equivalent information to what they put in it at an earlier time. This change removes mentions of "offset" where it was used to indicate storing indices, and uses "index" instead.
This is a breaking change to many uses of flat container.