type: revert @types/react and @types/react-dom to 18.x #434

afc163 · 2024-12-30T08:59:06Z

Summary by CodeRabbit

依赖项更新
- 将 @types/react 类型定义从版本 ^19.0.2 降级到 ^18.0.0
- 将 @types/react-dom 类型定义从版本 ^19.0.2 降级到 ^18.0.0

coderabbitai · 2024-12-30T08:59:13Z

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)

bun.lockb is excluded by !**/bun.lockb

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough

变更概述

演练

此拉取请求主要修改了 package.json 文件中 @ant-design/x 包的依赖版本。具体变更包括将 @types/react 和 @types/react-dom 的类型定义版本从 19.0.2 降级到 18.0.0。这表明项目暂时回退到了 React 和 React DOM 的较早版本的类型定义。

变更

文件	变更描述
`package.json`	- `@types/react` 版本从 `^19.0.2` 降至 `^18.0.0` - `@types/react-dom` 版本从 `^19.0.2` 降至 `^18.0.0`

可能相关的 PR

chore: Update package.json #110：更新了 package.json 文件中的 React 和 React DOM 对等依赖
Revert "chore(deps-dev): bump react from 18.3.1 to 19.0.0" #433：将 React 和 React DOM 版本从 ^19.0.0 降级到 ^18.3.1

诗歌

兔子代码魔法师，
版本降级别慌张，
React 十八回归时，
类型定义轻轻放，
代码路上再探索！
🐰✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2024-12-30T08:59:16Z

petercat-assistant · 2024-12-30T08:59:21Z

Walkthrough\nThis pull request reverts the `@types/react` and `@types/react-dom` packages from version 19.x to 18.x in the `package.json` file. This change is likely aimed at maintaining compatibility with other dependencies or project requirements that are not yet compatible with version 19.x.\n\n### Changes\n| File | Summary |\n|---------------|----------------------------------------------------------|\n| package.json | Reverted `@types/react` and `@types/react-dom` to 18.x. |

package.json

codecov · 2024-12-30T09:00:48Z

Bundle Report

Bundle size has no change ✅

codecov · 2024-12-30T09:02:22Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.45%. Comparing base (b21e9b7) to head (d955f4b).
Report is 5 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #434   +/-   ##
=======================================
  Coverage   91.45%   91.45%           
=======================================
  Files          67       67           
  Lines        1462     1462           
  Branches      385      370   -15     
=======================================
  Hits         1337     1337           
  Misses        125      125

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cloudflare-workers-and-pages · 2024-12-30T09:06:37Z

Deploying ant-design-x with Cloudflare Pages

Latest commit:	`d955f4b`
Status:	✅ Deploy successful!
Preview URL:	https://3143574d.ant-design-x.pages.dev
Branch Preview URL:	https://revert-react-types.ant-design-x.pages.dev

View logs

socket-security · 2024-12-30T09:08:14Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@types/[email protected]	None	`0`	37.9 kB	types
npm/@types/[email protected]	None	`0`	439 kB	types

🚮 Removed packages: npm/@types/[email protected], npm/@types/[email protected]

View full report↗︎

YumoImer · 2024-12-30T10:22:14Z

先不用回退，这个问题我解决了。@afc163

revert: @types/react and @types/react-dom to 18.x

dcbcbc7

petercat-assistant bot reviewed Dec 30, 2024

View reviewed changes

package.json Show resolved Hide resolved

petercat-assistant bot reviewed Dec 30, 2024

View reviewed changes

package.json Show resolved Hide resolved

afc163 changed the title ~~revert: @types/react and @types/react-dom to 18.x~~ type: react @types/react and @types/react-dom to 18.x Dec 30, 2024

afc163 changed the title ~~type: react @types/react and @types/react-dom to 18.x~~ type: revert @types/react and @types/react-dom to 18.x Dec 30, 2024

update bun lock file

2a09a78

update bun lock file

d955f4b

afc163 enabled auto-merge (squash) December 30, 2024 09:08

afc163 closed this Dec 30, 2024

auto-merge was automatically disabled December 30, 2024 10:27
Pull request was closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

type: revert @types/react and @types/react-dom to 18.x #434

type: revert @types/react and @types/react-dom to 18.x #434

afc163 commented Dec 30, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Dec 30, 2024 •

edited

Loading

Review skipped

变更概述

演练

变更

可能相关的 PR

诗歌

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

github-actions bot commented Dec 30, 2024 •

edited

Loading

petercat-assistant bot commented Dec 30, 2024

codecov bot commented Dec 30, 2024 •

edited

Loading

codecov bot commented Dec 30, 2024 •

edited

Loading

cloudflare-workers-and-pages bot commented Dec 30, 2024 •

edited

Loading

socket-security bot commented Dec 30, 2024

YumoImer commented Dec 30, 2024

type: revert @types/react and @types/react-dom to 18.x #434

type: revert @types/react and @types/react-dom to 18.x #434

Conversation

afc163 commented Dec 30, 2024 • edited by coderabbitai bot Loading

Summary by CodeRabbit

coderabbitai bot commented Dec 30, 2024 • edited Loading

Review skipped

变更概述

演练

变更

可能相关的 PR

诗歌

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

github-actions bot commented Dec 30, 2024 • edited Loading

petercat-assistant bot commented Dec 30, 2024

codecov bot commented Dec 30, 2024 • edited Loading

Bundle Report

codecov bot commented Dec 30, 2024 • edited Loading

Codecov Report

cloudflare-workers-and-pages bot commented Dec 30, 2024 • edited Loading

Deploying ant-design-x with Cloudflare Pages

socket-security bot commented Dec 30, 2024

YumoImer commented Dec 30, 2024

afc163 commented Dec 30, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Dec 30, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

github-actions bot commented Dec 30, 2024 •

edited

Loading

codecov bot commented Dec 30, 2024 •

edited

Loading

codecov bot commented Dec 30, 2024 •

edited

Loading

cloudflare-workers-and-pages bot commented Dec 30, 2024 •

edited

Loading