Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove @solana/wallet-adapter-wallets re-exports dep #885

Merged
merged 3 commits into from
May 20, 2024

Conversation

gin-lsl
Copy link
Collaborator

@gin-lsl gin-lsl commented May 20, 2024

[中文版模板 / Chinese template]

💡 Background and solution

我们其实只用到了 @solana/wallet-adapter-wallets 包中的有限的几个依赖,没有必要依赖整个包。

这样也应该能解决 #827 的问题,它其实只是某个包中的依赖有问题。


We actually only use a limited number of dependencies in the @solana/wallet-adapter-wallets package, and there is no need to rely on the entire package.

This should also solve the problem of #827, which is actually just a dependency problem in a certain package.

🔗 Related issue link

Copy link

vercel bot commented May 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ant-design-web3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 20, 2024 5:56am

Copy link

changeset-bot bot commented May 20, 2024

🦋 Changeset detected

Latest commit: 129ef57

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ant-design/web3-solana Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

github-actions bot commented May 20, 2024

Preview is ready

Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (859ebd7) to head (129ef57).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #885   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          708       708           
  Lines        21449     21449           
  Branches      1214      1214           
=========================================
  Hits         21449     21449           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yutingzhao1991
Copy link
Collaborator

加一个 changelog

Copy link

@gin-lsl You can run the pnpm changeset command locally to generate a changelog. Please refer to the operation precautions. https://web3.ant.design/guide/changelog

@gin-lsl 可以在本地运行 pnpm changeset 命令生成 changelog, 操作注意事项参考:https://web3.ant.design/guide/changelog-cn

@gin-lsl
Copy link
Collaborator Author

gin-lsl commented May 20, 2024

不确定作为 patch 是否合适。

@yutingzhao1991
Copy link
Collaborator

不确定作为 patch 是否合适。

API 没有调整 patch 应该没问题。

@gin-lsl gin-lsl merged commit 5312696 into main May 20, 2024
12 checks passed
@gin-lsl gin-lsl deleted the fix/solana-deps branch May 20, 2024 06:09
@gin-lsl
Copy link
Collaborator Author

gin-lsl commented May 20, 2024

这个是否需要先对 web3-solana 发个版本 @jeasonstudio

@yutingzhao1991
Copy link
Collaborator

这个是否需要先对 web3-solana 发个版本 @jeasonstudio

可以发,整个发个版本就行。master 上有影响使用的问题都可以随时发版本。

@jeasonstudio
Copy link
Collaborator

今天发掉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants