-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Remove @solana/wallet-adapter-wallets re-exports dep #885
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 129ef57 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #885 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 708 708
Lines 21449 21449
Branches 1214 1214
=========================================
Hits 21449 21449 ☔ View full report in Codecov by Sentry. |
加一个 changelog |
@gin-lsl You can run the @gin-lsl 可以在本地运行 |
不确定作为 patch 是否合适。 |
API 没有调整 patch 应该没问题。 |
这个是否需要先对 web3-solana 发个版本 @jeasonstudio |
可以发,整个发个版本就行。master 上有影响使用的问题都可以随时发版本。 |
今天发掉 |
[中文版模板 / Chinese template]
💡 Background and solution
我们其实只用到了 @solana/wallet-adapter-wallets 包中的有限的几个依赖,没有必要依赖整个包。
这样也应该能解决 #827 的问题,它其实只是某个包中的依赖有问题。
We actually only use a limited number of dependencies in the @solana/wallet-adapter-wallets package, and there is no need to rely on the entire package.
This should also solve the problem of #827, which is actually just a dependency problem in a certain package.
🔗 Related issue link