-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the names of some icons and add a new category for token icons #443
Conversation
…e token, and add a new token icons category.
🦋 Changeset detectedLatest commit: 72b9f9a The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
In addition, the Dumi documentation content has also been updated. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #443 +/- ##
==========================================
- Coverage 98.82% 98.82% -0.01%
==========================================
Files 91 91
Lines 4008 4006 -2
Branches 376 376
==========================================
- Hits 3961 3959 -2
Misses 45 45
Partials 2 2 ☔ View full report in Codecov by Sentry. |
.changeset/lazy-dolls-bake.md
Outdated
'@ant-design/web3-icons': patch | ||
--- | ||
|
||
Fix the correct name for the Cronos icon, update the name for the token, and add a new token icons category. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the correct name for the Cronos icon, update the name for the token, and add a new token icons category. | |
fix: Fix the correct name for the Cronos icon, update the name for the token, and add a new token icons category. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the suggestion. The wording has been adjusted accordingly.
const tool = [ | ||
'CoinbaseWallet', | ||
'Etherscan', | ||
'MetaMask', | ||
'WalletConnect', | ||
'TokenPocket', | ||
'Safeheron', | ||
'Uniswap', | ||
'PancakeSwap', | ||
'SushiSwap', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Due to duplicate IDs, when multiple icons are present on the page, there may be display issues.
You can fix it like: #346
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the correct name for the Cronos icon, update the name for the token, and add a new token icons category.