Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the names of some icons and add a new category for token icons #443

Merged
merged 6 commits into from
Jan 3, 2024
Merged

Conversation

cong1223
Copy link
Contributor

@cong1223 cong1223 commented Jan 2, 2024

Fix the correct name for the Cronos icon, update the name for the token, and add a new token icons category.

…e token, and add a new token icons category.
Copy link

changeset-bot bot commented Jan 2, 2024

🦋 Changeset detected

Latest commit: 72b9f9a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@ant-design/web3-icons Patch
@ant-design/web3-assets Patch
@ant-design/web3 Patch
@ant-design/web3-wagmi Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ant-design-web3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 3, 2024 2:12am

Copy link

github-actions bot commented Jan 2, 2024

@cong1223
Copy link
Contributor Author

cong1223 commented Jan 2, 2024

In addition, the Dumi documentation content has also been updated.

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (64a2de3) 98.82% compared to head (72b9f9a) 98.82%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #443      +/-   ##
==========================================
- Coverage   98.82%   98.82%   -0.01%     
==========================================
  Files          91       91              
  Lines        4008     4006       -2     
  Branches      376      376              
==========================================
- Hits         3961     3959       -2     
  Misses         45       45              
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

'@ant-design/web3-icons': patch
---

Fix the correct name for the Cronos icon, update the name for the token, and add a new token icons category.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Fix the correct name for the Cronos icon, update the name for the token, and add a new token icons category.
fix: Fix the correct name for the Cronos icon, update the name for the token, and add a new token icons category.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the suggestion. The wording has been adjusted accordingly.

const tool = [
'CoinbaseWallet',
'Etherscan',
'MetaMask',
'WalletConnect',
'TokenPocket',
'Safeheron',
'Uniswap',
'PancakeSwap',
'SushiSwap',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Due to duplicate IDs, when multiple icons are present on the page, there may be display issues.

You can fix it like: #346

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the suggestion. The issue has been fixed.
image

@yutingzhao1991 yutingzhao1991 merged commit dc083a3 into ant-design:main Jan 3, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants