Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add commonly used icons for Celo, Aave, Moonbeam, and more. #441

Merged
merged 4 commits into from
Jan 2, 2024
Merged

feat: Add commonly used icons for Celo, Aave, Moonbeam, and more. #441

merged 4 commits into from
Jan 2, 2024

Conversation

cong1223
Copy link
Contributor

@cong1223 cong1223 commented Jan 2, 2024

Added new icons:

  1. aave
  2. celo
  3. cronos
  4. dai
  5. moonbeam
  6. pancakeswap
  7. sui
  8. sushiswap
  9. uniswap
  10. usdt
  11. wbtc

Copy link

changeset-bot bot commented Jan 2, 2024

🦋 Changeset detected

Latest commit: fd65dc0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@ant-design/web3-icons Minor
@ant-design/web3-assets Patch
@ant-design/web3 Patch
@ant-design/web3-wagmi Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ant-design-web3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2024 8:24am

Copy link

github-actions bot commented Jan 2, 2024

@cong1223
Copy link
Contributor Author

cong1223 commented Jan 2, 2024

Associate issue, #438.

@kiner-tang
Copy link
Member

CI broken, you can run pnpm test:update to update snapshots

@cong1223
Copy link
Contributor Author

cong1223 commented Jan 2, 2024

CI broken, you can run pnpm test:update to update snapshots

Thx bro, i will do it

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (76b972a) 98.70% compared to head (fd65dc0) 98.77%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #441      +/-   ##
==========================================
+ Coverage   98.70%   98.77%   +0.07%     
==========================================
  Files          72       83      +11     
  Lines        3620     3844     +224     
  Branches      357      368      +11     
==========================================
+ Hits         3573     3797     +224     
  Misses         45       45              
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cong1223
Copy link
Contributor Author

cong1223 commented Jan 2, 2024

CI broken, you can run pnpm test:update to update snapshots

Thx bro, i will do it

done

<?xml version="1.0" encoding="utf-8"?>
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 14.1 11.8">
<style type="text/css">
.st0{fill:#5FC0C1;}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe its better to change the class name?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

class name duplicate

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe its better to change the class name?

Thank you for pointing out the issue, but I'm wondering if there is really a need for semanticization. These icons generally don't require modification because many SVG files are converted from other formats like PNG by machines.

@cong1223
Copy link
Contributor Author

cong1223 commented Jan 2, 2024

The aforementioned issues have all been addressed. Please feel free to review them again. Thank you for your hard work. @gin-lsl

@gin-lsl gin-lsl merged commit c549a09 into ant-design:main Jan 2, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants