-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add commonly used icons for Celo, Aave, Moonbeam, and more. #441
Conversation
🦋 Changeset detectedLatest commit: fd65dc0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Associate issue, #438. |
CI broken, you can run |
Thx bro, i will do it |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #441 +/- ##
==========================================
+ Coverage 98.70% 98.77% +0.07%
==========================================
Files 72 83 +11
Lines 3620 3844 +224
Branches 357 368 +11
==========================================
+ Hits 3573 3797 +224
Misses 45 45
Partials 2 2 ☔ View full report in Codecov by Sentry. |
done |
<?xml version="1.0" encoding="utf-8"?> | ||
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 14.1 11.8"> | ||
<style type="text/css"> | ||
.st0{fill:#5FC0C1;} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe its better to change the class name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe its better to change the class name?
Thank you for pointing out the issue, but I'm wondering if there is really a need for semanticization. These icons generally don't require modification because many SVG files are converted from other formats like PNG by machines.
The aforementioned issues have all been addressed. Please feel free to review them again. Thank you for your hard work. @gin-lsl |
Added new icons: