Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make new workunit backward compatible #1232

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

matoval
Copy link
Collaborator

@matoval matoval commented Dec 2, 2024

make new workunit backward compatible

@matoval matoval marked this pull request as ready for review December 2, 2024 17:28
Copy link

sonarcloud bot commented Dec 2, 2024

@AaronH88 AaronH88 changed the title make new workunit backward compatible Make new workunit backward compatible Dec 2, 2024
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 40.44%. Comparing base (aa2756f) to head (a65a760).
Report is 1 commits behind head on devel.

Files with missing lines Patch % Lines
pkg/workceptor/remote_work.go 0.00% 1 Missing ⚠️
@@            Coverage Diff             @@
##            devel    #1232      +/-   ##
==========================================
+ Coverage   39.99%   40.44%   +0.44%     
==========================================
  Files          45       48       +3     
  Lines        9266     9846     +580     
==========================================
+ Hits         3706     3982     +276     
- Misses       5283     5585     +302     
- Partials      277      279       +2     
Files with missing lines Coverage Δ
pkg/workceptor/workceptor.go 50.44% <100.00%> (ø)
pkg/workceptor/remote_work.go 10.83% <0.00%> (ø)

... and 6 files with indirect coverage changes

Components Coverage Δ
Go 39.88% <50.00%> (-0.11%) ⬇️
Receptorctl 49.31% <ø> (∅)

Copy link
Contributor

@AaronH88 AaronH88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

tested locally with
control (devel) to ee (1.4.9)
control (1.4.9) to ee (devel)
control (devel) to ee (devel)
All pass

@AaronH88 AaronH88 merged commit 037c78f into ansible:devel Dec 2, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants