Update quic to use go 1.22 #1214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i think with this PR we can also change the github actions to move to 1.22, Or have the actions PR merged first, what do you think? |
AaronH88
reviewed
Nov 21, 2024
| google.golang.org/appengine v1.6.8 // indirect | ||
| google.golang.org/protobuf v1.33.0 // indirect | ||
| google.golang.org/protobuf v1.34.1 // indirect |
There was a problem hiding this comment.
you will also need to delete line 96 😄
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## devel #1214 +/- ##
==========================================
+ Coverage 39.06% 39.71% +0.65%
==========================================
Files 45 48 +3
Lines 9260 9840 +580
==========================================
+ Hits 3617 3908 +291
- Misses 5371 5660 +289
Partials 272 272 see 5 files with indirect coverage changes
🚨 Try these New Features:
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update quic to use go 1.22