Add udp dialer test (#1179)

ansible · Oct 17, 2024 · 21ce884 · 21ce884
1 parent 46dd998
commit 21ce884
Showing 1 changed file with 55 additions and 15 deletions.
diff --git a/pkg/backends/udp_test.go b/pkg/backends/udp_test.go
@@ -16,15 +16,6 @@ func TestNewUDPListener(t *testing.T) {
 		logger  *logger.ReceptorLogger
 	}
 
-	goodLogger := logger.NewReceptorLogger("UDPtest")
-	goodUDPListener := &UDPListener{
-		laddr:           &net.UDPAddr{},
-		conn:            &net.UDPConn{},
-		sessChan:        make(chan *UDPListenerSession),
-		sessRegLock:     sync.RWMutex{},
-		sessionRegistry: make(map[string]*UDPListenerSession),
-		logger:          goodLogger,
-	}
 	tests := []struct {
 		name    string
 		args    args
@@ -34,10 +25,9 @@ func TestNewUDPListener(t *testing.T) {
 		{
 			name: "Positive",
 			args: args{
-				address: "127.0.0.1:9998",
-				logger:  goodLogger,
+				address: "127.0.0.1:9997",
+				logger:  logger.NewReceptorLogger("UDPtest"),
 			},
-			want:    goodUDPListener,
 			wantErr: false,
 		},
 	}
@@ -65,7 +55,6 @@ func TestUDPListenerStart(t *testing.T) {
 		logger          *logger.ReceptorLogger
 	}
 
-	goodLogger := logger.NewReceptorLogger("UDPtest")
 	type args struct {
 		ctx context.Context
 		wg  *sync.WaitGroup
@@ -88,7 +77,7 @@ func TestUDPListenerStart(t *testing.T) {
 				conn:            &net.UDPConn{},
 				sessChan:        make(chan *UDPListenerSession),
 				sessionRegistry: make(map[string]*UDPListenerSession),
-				logger:          goodLogger,
+				logger:          logger.NewReceptorLogger("UDPtest"),
 			},
 			args: args{
 				ctx: context.Background(),
@@ -115,7 +104,7 @@ func TestUDPListenerStart(t *testing.T) {
 			}
 			got, err := b.Start(tt.args.ctx, tt.args.wg)
 			if (err != nil) != tt.wantErr {
-				t.Errorf("UDPListener.Start() error = %v, wantErr %v", err, tt.wantErr)
+				t.Errorf("UDPListener.Start() error = %+v, wantErr %+v", err, tt.wantErr)
 
 				return
 			}
@@ -125,3 +114,54 @@ func TestUDPListenerStart(t *testing.T) {
 		})
 	}
 }
+
+func TestUDPDialerStart(t *testing.T) {
+	type fields struct {
+		address string
+		redial  bool
+		logger  *logger.ReceptorLogger
+	}
+	type args struct {
+		ctx context.Context
+		wg  *sync.WaitGroup
+	}
+	tests := []struct {
+		name    string
+		fields  fields
+		args    args
+		want    chan netceptor.BackendSession
+		wantErr bool
+	}{
+		{
+			name: "Positive",
+			fields: fields{
+				address: "127.0.0.1:9998",
+				redial:  true,
+				logger:  logger.NewReceptorLogger("UDPtest"),
+			},
+			args: args{
+				ctx: context.Background(),
+				wg:  &sync.WaitGroup{},
+			},
+			wantErr: false,
+		},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			b := &UDPDialer{
+				address: tt.fields.address,
+				redial:  tt.fields.redial,
+				logger:  tt.fields.logger,
+			}
+			got, err := b.Start(tt.args.ctx, tt.args.wg)
+			if (err != nil) != tt.wantErr {
+				t.Errorf("UDPDialer.Start() error = %+v, wantErr %+v", err, tt.wantErr)
+
+				return
+			}
+			if got == nil {
+				t.Errorf("UDPDialer.Start() returned nil")
+			}
+		})
+	}
+}