Create additional nsgroup objects #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- install package 'cargo' on the image (required to build 'cryptography') - update flaskapp.py to add support for additional nsgroup:delegation (required for infobloxopen/infoblox-ansible#56)
badnetmask
added a commit
to badnetmask/infoblox-ansible
that referenced
this pull request
Nov 21, 2021
NOTE: automated github tests in this repo will fail until this is merged, and a new image is pushed to quay.io: ansible/nios-test-container#8
mattclay
requested changes
Dec 1, 2021
Co-authored-by: Matt Clay <[email protected]>
Co-authored-by: Matt Clay <[email protected]>
Co-authored-by: Matt Clay <[email protected]>
mattclay
reviewed
Dec 1, 2021
There was a problem hiding this comment.
@badnetmask Have you verified this updated container works with all of the existing infoblox collection tests, as well as the changes in infobloxopen/infoblox-ansible#56?
|
I just ran all the integration tests on my local machine, using my branch created for the PR. All passed just fine. |
mattclay
approved these changes
Dec 1, 2021
JkhatriInfobox
pushed a commit
to infobloxopen/infoblox-ansible
that referenced
this pull request
Aug 22, 2024
* clarify that nios_nsgroup creates authoritative groups
* add nios_nsgroup_forwardingmember
* add nios_nsgroup_forwardingmember
* fix sanity tests
* fix module description
* add nios_nsgroup_delegation
* add nios_nsgroup_stubmember
* fix bad merge
* remove deprecated files
* modify ib_spec to fix sanity errors
* add missing import to fix sanity tests
* include integration test for nios_nsgroup_delegation (fails on my local system, wanna check what happens on github)
* fix incorrect object type for 'extattrs'
* correct integration tests for nios_nsgroup_delegation_idempotence.yml
NOTE: requires update on 'nios-test-container'
which has not been pushed yet
* fix typos on nios_nsgroup_delegation_idempotence integration test
* add remaining integration tests for all nsgroup types
NOTE: automated github tests in this repo will fail until this is
merged, and a new image is pushed to quay.io:
ansible/nios-test-container#8
* fix sanity tests
* retrigger checks
* retrigger checks
* fix integration and sanity tests
* fix sanity tests for ansible devel branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As required for infobloxopen/infoblox-ansible#56, I patched this app to add support for the additional nsgroup objects.
However, I found a couple of problems during my build, which may need some further attention before merging:
cryptographyPython package, which required installingcargoviaapk.rustversion installed on Alpine 3.6 is too old, so I updated the Dockerfile to use 3.14 instead.Please, let me know your thoughts about this.
(CC: @anagha-infoblox)