Fix: Update default globbing pattern for collection matching

[trfore]

This update:

• restricts the glob matching for molecule test
• updates the default value for MOLECULE_GLOB="**/molecule/*/molecule.yml"

This allows:

• users to call molecule from the collection folder and molecule will use the collection name in the ephemeral cache, .cache/molecule/COLLECTION_NAME.

WARNING:
If working within the ANSIBLE_COLLECTIONS_PATH directory, e.g. ~/.ansible/collections/ansible_collections/COLLECTION_NAME (default), using the new default setting MOLECULE_GLOB="**/molecule/*/molecule.yml" will globber clobber and delete the collection folder. This occurs in the presence of a galaxy.yml - as molecule calls ansible_compat.runtime(isolate=False) and will run ansible_compat.runtime.prepare_environment. However, if you delete the galaxy.yml OR chdir into COLLECTION_NAME/extensions and it will not delete the collection folder.

Currently (v24.2.1):
Calling molecule list will find all molecule.yml files within a collection folder that use a nested dir structure, i.e
COLLECTION_NAME/extensions/molecule/SCENARIO_NAME/molecule.yml. As it calls base.get_configs and sets the argument glob=str"**/molecule/*/molecule.yml".

This does not occur with molecule test, as it calls to base.execute_cmdline_scenarios and uses
MOLECULE_GLOB = os.environ.get("MOLECULE_GLOB", "molecule/*/molecule.yml").

Attempting to set an env var MOLECULE_GLOB="**/molecule/*/molecule.yml" will fail, as test attempts to insert the scenario name into every wild-card. But, this fuzzy matching acts as a safe guard against deleting the collection when working within the same ANSIBLE_COLLECTIONS_PATH directory:

$ MOLECULE_GLOB="**/molecule/*/molecule.yml" molecule test
CRITICAL 'defaultdefault/molecule/default/molecule.yml' glob failed.

[github-actions]

Label error. Requires exactly 1 of: bug, enhancement, major, minor, patch, skip-changelog. Found:

[trfore]

So I was curious why molecule list is collection aware and all the other commands are not. The current work-around for making molecule collection aware is to use one of the following approaches:

$ MOLECULE_GLOB="./extensions/molecule/*/molecule.yml" molecule test
$ MOLECULE_GLOB="$(pwd)/extensions/molecule/*/molecule.yml" molecule test

• This fix, partially addresses RFE: Make molecule collection aware #4000 and CRITICAL 'molecule/default/molecule.yml' glob failed. Exiting - Unable to run molecule  #4117.

• Is compatiable with PR Use MOLECULE_GLOB environment variable for list command as well #4160.

• Yet, it easily exposes one of the current bugs within molecule (Molecule Reset overwrites projects in COLLECTIONS_PATHS #4061) if end-users are working within the same directory as ANSIBLE_COLLECTIONS_PATH.