chore: auto fixes from pre-commit.com hooks

tests/conftest.py

@@ -81,7 +81,7 @@ def _no_color(monkeypatch: pytest.MonkeyPatch) -> None:
     monkeypatch.delitem(os.environ, "FORCE_COLOR", raising=False)
 
 
-@pytest.fixture()
+@pytest.fixture
 def resources_folder_path() -> Path:
     """Return the path to the resources folder.
 
@@ -127,7 +127,7 @@ def reset_pytest_vars(monkeypatch):  # type: ignore[no-untyped-def]  # noqa: ANN
             monkeypatch.delenv(var_name, raising=False)
 
 
-@pytest.fixture()
+@pytest.fixture
 def test_fixture_dir(request: pytest.FixtureRequest) -> Path:
     """Provide the fixture directory for a given test.
 

tests/integration/test_command.py

@@ -73,7 +73,7 @@ class ParamDefault(TypedDict):
 }
 
 
-@pytest.mark.extensive()
+@pytest.mark.extensive
 @pytest.mark.parametrize(**PARAMS_DEFAULT)
 @pytest.mark.usefixtures("with_scenario")
 @pytest.mark.parametrize(
@@ -112,7 +112,7 @@ def test_command(
         assert "PLAY RECAP" in result.stdout
 
 
-@pytest.mark.extensive()
+@pytest.mark.extensive
 @pytest.mark.parametrize(**PARAMS_DEFAULT)
 @pytest.mark.usefixtures("with_scenario")
 def test_command_idempotence(test_ephemeral_dir_env: dict[str, str], scenario_name: str) -> None:
@@ -200,7 +200,7 @@ def test_command_list_with_format_plain(
     assert result.stdout == "instance        default ansible default false   false\n"
 
 
-@pytest.mark.extensive()
+@pytest.mark.extensive
 @pytest.mark.parametrize(**PARAMS_DEFAULT)
 @pytest.mark.usefixtures("with_scenario")
 @pytest.mark.parametrize(("platform", "missing"), (("instance", False), ("gonzo", True)))

tests/unit/command/conftest.py

@@ -22,12 +22,12 @@
 import pytest
 
 
-@pytest.fixture()
+@pytest.fixture
 def command_patched_ansible_create(mocker):  # type: ignore[no-untyped-def]  # noqa: ANN001, ANN201, D103
     return mocker.patch("molecule.provisioner.ansible.Ansible.create")
 
 
-@pytest.fixture()
+@pytest.fixture
 def command_driver_delegated_section_data():  # type: ignore[no-untyped-def]  # noqa: ANN201, D103
     x = {
         "driver": {
@@ -42,6 +42,6 @@ def command_driver_delegated_section_data():  # type: ignore[no-untyped-def]  #
     return x  # noqa: RET504
 
 
-@pytest.fixture()
+@pytest.fixture
 def command_driver_delegated_managed_section_data():  # type: ignore[no-untyped-def]  # noqa: ANN201, D103
     return {"driver": {"name": "default", "managed": True}}

tests/unit/command/test_check.py

@@ -34,7 +34,7 @@
     from molecule import config
 
 
-@pytest.fixture()
+@pytest.fixture
 def _patched_ansible_check(mocker: MockerFixture) -> MagicMock:
     return mocker.patch("molecule.provisioner.ansible.Ansible.check")
 

tests/unit/command/test_cleanup.py

@@ -38,14 +38,14 @@
     from molecule.types import ProvisionerData
 
 
-@pytest.fixture()
+@pytest.fixture
 def _command_provisioner_section_with_cleanup_data() -> (
     dict[Literal["provisioner"], ProvisionerData]
 ):
     return {"provisioner": {"name": "ansible", "playbooks": {"cleanup": "cleanup.yml"}}}
 
 
-@pytest.fixture()
+@pytest.fixture
 def _patched_ansible_cleanup(mocker: MockerFixture) -> MagicMock:
     return mocker.patch("molecule.provisioner.ansible.Ansible.cleanup")
 

tests/unit/command/test_create.py

@@ -34,7 +34,7 @@
     from molecule import config
 
 
-@pytest.fixture()
+@pytest.fixture
 def _patched_create_setup(mocker: MockerFixture) -> MagicMock:
     return mocker.patch("molecule.command.create.Create._setup")
 

tests/unit/command/test_destroy.py

@@ -34,12 +34,12 @@
     from molecule import config
 
 
-@pytest.fixture()
+@pytest.fixture
 def _patched_ansible_destroy(mocker: MockerFixture) -> MagicMock:
     return mocker.patch("molecule.provisioner.ansible.Ansible.destroy")
 
 
-@pytest.fixture()
+@pytest.fixture
 def _patched_destroy_setup(mocker: MockerFixture) -> MagicMock:
     return mocker.patch("molecule.command.destroy.Destroy._setup")
 

tests/unit/command/test_idempotence.py

@@ -34,15 +34,15 @@
     from molecule import config
 
 
-@pytest.fixture()
+@pytest.fixture
 def _patched_is_idempotent(mocker: MockerFixture) -> Mock:
     return mocker.patch("molecule.command.idempotence.Idempotence._is_idempotent")
 
 
 # NOTE(retr0h): The use of the `patched_config_validate` fixture, disables
 # config.Config._validate from executing.  Thus preventing odd side-effects
 # throughout patched.assert_called unit tests.
-@pytest.fixture()
+@pytest.fixture
 def _instance(patched_config_validate, config_instance: config.Config):  # type: ignore[no-untyped-def]  # noqa: ANN001, ANN202, ARG001
     config_instance.state.change_state("converged", True)  # noqa: FBT003
 

tests/unit/command/test_login.py

@@ -32,7 +32,7 @@
     from molecule import config
 
 
-@pytest.fixture()
+@pytest.fixture
 def _instance(config_instance: config.Config) -> login.Login:
     config_instance.state.change_state("created", value=True)
 

tests/unit/command/test_prepare.py

@@ -35,7 +35,7 @@
     from pytest_mock import MockerFixture
 
 
-@pytest.fixture()
+@pytest.fixture
 def _patched_ansible_prepare(mocker: MockerFixture) -> MagicMock:
     return mocker.patch("molecule.provisioner.ansible.Ansible.prepare")
 

tests/unit/command/test_side_effect.py

@@ -38,7 +38,7 @@
     from molecule.types import ProvisionerData
 
 
-@pytest.fixture()
+@pytest.fixture
 def _command_provisioner_section_with_side_effect_data() -> (
     dict[Literal["provisioner"], ProvisionerData]
 ):
@@ -50,7 +50,7 @@ def _command_provisioner_section_with_side_effect_data() -> (
     }
 
 
-@pytest.fixture()
+@pytest.fixture
 def _patched_ansible_side_effect(mocker: MockerFixture) -> MagicMock:
     return mocker.patch("molecule.provisioner.ansible.Ansible.side_effect")
 

tests/unit/command/test_syntax.py

@@ -34,7 +34,7 @@
     from molecule import config
 
 
-@pytest.fixture()
+@pytest.fixture
 def _patched_ansible_syntax(mocker: MockerFixture) -> MagicMock:
     return mocker.patch("molecule.provisioner.ansible.Ansible.syntax")
 

tests/unit/conftest.py

@@ -69,7 +69,7 @@ def fixture_molecule_data() -> dict[str, Any]:
     }
 
 
-@pytest.fixture()
+@pytest.fixture
 def config_instance(
     monkeypatch: pytest.MonkeyPatch,
     molecule_data: dict[str, Any],
@@ -121,27 +121,27 @@ def _filter_ignored_scenarios(scenario_paths: list[str]) -> list[str]:
 # Mocks
 
 
-@pytest.fixture()
+@pytest.fixture
 def patched_print_debug(mocker):  # type: ignore[no-untyped-def]  # noqa: ANN001, ANN201, D103
     return mocker.patch("molecule.util.print_debug")
 
 
-@pytest.fixture()
+@pytest.fixture
 def patched_logger_info(mocker):  # type: ignore[no-untyped-def]  # noqa: ANN001, ANN201, D103
     return mocker.patch("logging.Logger.info")
 
 
-@pytest.fixture()
+@pytest.fixture
 def patched_logger_debug(mocker):  # type: ignore[no-untyped-def]  # noqa: ANN001, ANN201, D103
     return mocker.patch("logging.Logger.debug")
 
 
-@pytest.fixture()
+@pytest.fixture
 def patched_logger_error(mocker):  # type: ignore[no-untyped-def]  # noqa: ANN001, ANN201, D103
     return mocker.patch("logging.Logger.error")
 
 
-@pytest.fixture()
+@pytest.fixture
 def patched_run_command(mocker):  # type: ignore[no-untyped-def]  # noqa: ANN001, ANN201, D103
     m = mocker.patch("molecule.util.run_command")
     m.return_value = CompletedProcess(
@@ -154,36 +154,36 @@ def patched_run_command(mocker):  # type: ignore[no-untyped-def]  # noqa: ANN001
     return m
 
 
-@pytest.fixture()
+@pytest.fixture
 def patched_ansible_converge(mocker: MockerFixture) -> Mock:  # noqa: D103
     m = mocker.patch("molecule.provisioner.ansible.Ansible.converge")
     m.return_value = "patched-ansible-converge-stdout"
 
     return m
 
 
-@pytest.fixture()
+@pytest.fixture
 def patched_add_or_update_vars(mocker):  # type: ignore[no-untyped-def]  # noqa: ANN001, ANN201, D103
     return mocker.patch("molecule.provisioner.ansible.Ansible._add_or_update_vars")
 
 
-@pytest.fixture()
+@pytest.fixture
 def patched_ansible_galaxy(mocker):  # type: ignore[no-untyped-def]  # noqa: ANN001, ANN201, D103
     return mocker.patch("molecule.dependency.ansible_galaxy.AnsibleGalaxy.execute")
 
 
-@pytest.fixture()
+@pytest.fixture
 def patched_default_verifier(mocker):  # type: ignore[no-untyped-def]  # noqa: ANN001, ANN201, D103
     return mocker.patch("molecule.verifier.ansible.Ansible.execute")
 
 
-@pytest.fixture()
+@pytest.fixture
 def patched_scenario_setup(mocker):  # type: ignore[no-untyped-def]  # noqa: ANN001, ANN201, D103
     mocker.patch("molecule.config.Config.env")
 
     return mocker.patch("molecule.scenario.Scenario._setup")
 
 
-@pytest.fixture()
+@pytest.fixture
 def patched_config_validate(mocker):  # type: ignore[no-untyped-def]  # noqa: ANN001, ANN201, D103
     return mocker.patch("molecule.config.Config._validate")

tests/unit/dependency/ansible_galaxy/test_collections.py

@@ -27,7 +27,7 @@
 from molecule.dependency.ansible_galaxy import collections
 
 
-@pytest.fixture()
+@pytest.fixture
 def _patched_ansible_galaxy_has_requirements_file(mocker):  # type: ignore[no-untyped-def]  # noqa: ANN001, ANN202
     m = mocker.patch(
         "molecule.dependency.ansible_galaxy.collections.Collections._has_requirements_file",
@@ -37,7 +37,7 @@ def _patched_ansible_galaxy_has_requirements_file(mocker):  # type: ignore[no-un
     return m
 
 
-@pytest.fixture()
+@pytest.fixture
 def _dependency_section_data():  # type: ignore[no-untyped-def]  # noqa: ANN202
     return {
         "dependency": {
@@ -51,7 +51,7 @@ def _dependency_section_data():  # type: ignore[no-untyped-def]  # noqa: ANN202
 # NOTE(retr0h): The use of the `patched_config_validate` fixture, disables
 # config.Config._validate from executing.  Thus preventing odd side-effects
 # throughout patched.assert_called unit tests.
-@pytest.fixture()
+@pytest.fixture
 def _instance(  # type: ignore[no-untyped-def]  # noqa: ANN202
     _dependency_section_data,  # noqa: ANN001
     patched_config_validate,  # noqa: ANN001, ARG001

tests/unit/dependency/ansible_galaxy/test_roles.py

@@ -27,7 +27,7 @@
 from molecule.dependency.ansible_galaxy import roles
 
 
-@pytest.fixture()
+@pytest.fixture
 def _patched_ansible_galaxy_has_requirements_file(mocker):  # type: ignore[no-untyped-def]  # noqa: ANN001, ANN202
     m = mocker.patch(
         "molecule.dependency.ansible_galaxy.roles.Roles._has_requirements_file",
@@ -37,7 +37,7 @@ def _patched_ansible_galaxy_has_requirements_file(mocker):  # type: ignore[no-un
     return m
 
 
-@pytest.fixture()
+@pytest.fixture
 def _dependency_section_data():  # type: ignore[no-untyped-def]  # noqa: ANN202
     return {
         "dependency": {
@@ -51,7 +51,7 @@ def _dependency_section_data():  # type: ignore[no-untyped-def]  # noqa: ANN202
 # NOTE(retr0h): The use of the `patched_config_validate` fixture, disables
 # config.Config._validate from executing.  Thus preventing odd side-effects
 # throughout patched.assert_called unit tests.
-@pytest.fixture()
+@pytest.fixture
 def _instance(  # type: ignore[no-untyped-def]  # noqa: ANN202
     _dependency_section_data,  # noqa: ANN001
     patched_config_validate,  # noqa: ANN001, ARG001

tests/unit/dependency/test_shell.py

@@ -25,7 +25,7 @@
 from molecule.dependency import shell
 
 
-@pytest.fixture()
+@pytest.fixture
 def _dependency_section_data():  # type: ignore[no-untyped-def]  # noqa: ANN202
     return {
         "dependency": {
@@ -40,7 +40,7 @@ def _dependency_section_data():  # type: ignore[no-untyped-def]  # noqa: ANN202
 # NOTE(retr0h): The use of the `patched_config_validate` fixture, disables
 # config.Config._validate from executing.  Thus preventing odd side-effects
 # throughout patched.assert_called unit tests.
-@pytest.fixture()
+@pytest.fixture
 def _instance(  # type: ignore[no-untyped-def]  # noqa: ANN202
     _dependency_section_data,  # noqa: ANN001
     patched_config_validate,  # noqa: ANN001, ARG001

tests/unit/driver/test_delegated.py

@@ -34,7 +34,7 @@
     from pytest_mock import MockerFixture
 
 
-@pytest.fixture()
+@pytest.fixture
 def _driver_managed_section_data():  # type: ignore[no-untyped-def]  # noqa: ANN202
     return {
         "driver": {
@@ -46,7 +46,7 @@ def _driver_managed_section_data():  # type: ignore[no-untyped-def]  # noqa: ANN
     }
 
 
-@pytest.fixture()
+@pytest.fixture
 def _driver_unmanaged_section_data():  # type: ignore[no-untyped-def]  # noqa: ANN202
     return {
         "driver": {
@@ -58,7 +58,7 @@ def _driver_unmanaged_section_data():  # type: ignore[no-untyped-def]  # noqa: A
     }
 
 
-@pytest.fixture()
+@pytest.fixture
 def _instance(config_instance: config.Config):  # type: ignore[no-untyped-def]  # noqa: ANN202
     return delegated.Delegated(config_instance)
 
@@ -340,7 +340,7 @@ def test_delegated_created(_instance):  # type: ignore[no-untyped-def]  # noqa:
     assert _instance._created() == "false"
 
 
-@pytest.fixture()
+@pytest.fixture
 def _driver_options_managed_section_data():  # type: ignore[no-untyped-def]  # noqa: ANN202
     return {"driver": {"options": {"managed": False}}}
 

tests/unit/model/v2/conftest.py

@@ -45,7 +45,7 @@ def fixture_molecule_file(resources_folder_path: Path) -> Path:
     return resources_folder_path / "molecule.yml"
 
 
-@pytest.fixture()
+@pytest.fixture
 def config(molecule_file: Path, request: pytest.FixtureRequest) -> dict[str, Any]:
     """Return merged molecule file data.
 
@@ -68,7 +68,7 @@ def config(molecule_file: Path, request: pytest.FixtureRequest) -> dict[str, Any
     return d  # type: ignore[no-any-return]
 
 
-@pytest.fixture()
+@pytest.fixture
 def _model_platforms_delegated_section_data() -> str:
     return """
 ---