Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: aap-17232 ensure job_args.limit for awx actions #605

Merged

Conversation

Alex-Izquierdo
Copy link
Contributor

Ensure that job_args.limit is honored in job_templates and workflow_template actions
Jira: https://issues.redhat.com/browse/AAP-17232

@Alex-Izquierdo Alex-Izquierdo requested review from mkanoor, bzwei and a team October 26, 2023 21:09
@Alex-Izquierdo Alex-Izquierdo force-pushed the render-jinja-template-args branch from b664c41 to 63b1497 Compare October 27, 2023 10:18
ansible_rulebook/util.py Outdated Show resolved Hide resolved
@Alex-Izquierdo Alex-Izquierdo requested a review from bzwei October 27, 2023 16:06
bzwei
bzwei previously approved these changes Oct 27, 2023
@Alex-Izquierdo Alex-Izquierdo merged commit 2a78982 into ansible:main Oct 30, 2023
8 checks passed
@benthomasson
Copy link
Contributor

benthomasson commented May 30, 2024

This is an incorrect fix for this issue and should be reverted. This is already supported by the the insert_hosts_to_meta event filter. https://github.com/ansible/event-driven-ansible/blob/main/extensions/eda/plugins/event_filter/insert_hosts_to_meta.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants