Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logic on prepare environment #310

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Fix logic on prepare environment #310

merged 1 commit into from
Aug 16, 2023

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Aug 10, 2023 •
edited
Loading

  • _prepare_ansible_paths should never be called more than once
  • install_local check should not be inside the galaxy file looping
  • Ignore folders that are not valid namaspaces
  • Adds tests
  • Fixes several regressions introduced by Fix find roles inside collection repository #297

@ssbarnea ssbarnea requested a review from a team as a code owner August 10, 2023 17:24
@github-actions github-actions bot added the bug Something isn't working label Aug 10, 2023
@ssbarnea
Ignore folders that are not valid namaspeces
77f5d5c 
- Adds tests
- Fixes several regressions introduced by #297
@ssbarnea ssbarnea changed the title Ignore folders that are not valid namaspeces Fix logic on prepare environment Aug 15, 2023
@ssbarnea ssbarnea merged commit 01f0448 into main Aug 16, 2023
@ssbarnea ssbarnea deleted the fix/deep branch August 16, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@audgirka audgirka Awaiting requested review from audgirka audgirka is a code owner automatically assigned from ansible/devtools

@shatakshiiii shatakshiiii Awaiting requested review from shatakshiiii shatakshiiii is a code owner automatically assigned from ansible/devtools

@Ruchip16 Ruchip16 Awaiting requested review from Ruchip16 Ruchip16 is a code owner automatically assigned from ansible/devtools

@cidrblock cidrblock Awaiting requested review from cidrblock

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ssbarnea