Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

junos_user: delete user role validation #537

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

romchi
Copy link

@romchi romchi commented Sep 3, 2024

SUMMARY

"Fixes #536" disable validation for user "class/role" field

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

junipernetworks.junos.junos_user

ADDITIONAL INFORMATION

If role/class name not valid we receive error message from Juniper system, not from module code.

@Ruchip16
Copy link
Contributor

Ruchip16 commented Sep 4, 2024

@romchi this is not an expected change and if you have some other option that the device supports then you can extend those but we are really not inclined towards removing those options directly.

@Ruchip16 Ruchip16 marked this pull request as draft September 4, 2024 09:48
@romchi
Copy link
Author

romchi commented Sep 4, 2024

@romchi this is not an expected change and if you have some other option that the device supports then you can extend those but we are really not inclined towards removing those options directly.

@Ruchip16 I am submitting a proposal for a pull request concerning the current method of login class validation within this library configuration. According to the Juniper documentation, while any number of login classes can be defined, only one can be assigned to an individual user account. Given this flexibility in the Juniper system, enforcing strict validation on login class names in our library seems unnecessary and restrictive.

Alternatively, we could adjust validation strategy to check other parameters, such as ensuring the input is a valid string, rather than hardcoding specific class names which may not be universally applicable.

Please let me know how you wish to proceed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable validation for user ROLE field
2 participants