Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added missing attributes to examples. #148

Merged
merged 5 commits into from
Dec 16, 2024
Merged

Added missing attributes to examples. #148

merged 5 commits into from
Dec 16, 2024

Conversation

Strange-Satwik
Copy link
Contributor

SUMMARY

Added the attributes to examples that are failing due to missing attributes.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

Updated modules:

  • cmci_action
  • cmci_create
  • cmci_delete
  • cmci_get
  • cmci_update

@andrewhughes101
Copy link
Collaborator

CI allowed

@Strange-Satwik Strange-Satwik marked this pull request as ready for review November 22, 2024 04:58
stewartfrancis
stewartfrancis requested changes Nov 28, 2024
View reviewed changes
Copy link
Collaborator

@stewartfrancis stewartfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry if I wasn't clear enough with those first comments. I think you should apply the same pattern you've taken for context to scope.

docs/source/modules/cmci_action.rst Outdated Show resolved Hide resolved
@stewartfrancis
Copy link
Collaborator

@andrewhughes101 this one's ready for a CI run now. Do I have the ability to permit? Looks like you tried previously!

@kiera-bennett
Copy link
Collaborator

CI allowed

@stewartfrancis stewartfrancis merged commit ed7ebe8 into ansible-collections:main Dec 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stewartfrancis stewartfrancis stewartfrancis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Strange-Satwik @andrewhughes101 @stewartfrancis @kiera-bennett